Android Oreo (8.0) Support #15601

AndrewJack · 2017-08-22T11:30:35Z

Apps targeting Android 8.0 (API level 26) cannot use TYPE_SYSTEM_OVERLAY and TYPE_SYSTEM_OVERLAY . Targeting 26 will cause the app to crash when in DEV_MODE.

https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt

This PR replaces uses of these overlay flags with the new TYPE_APPLICATION_OVERLAY when running on a device with Android 8.0 or later.

When using TYPE_APPLICATION_OVERLAY it still requires the SYSTEM_ALERT_WINDOW permission, just like previous android versions.
https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY

Test Plan

https://github.com/AndrewJack/react-native-android-oreo tested here

AndrewJack · 2017-08-22T11:34:40Z

Without the changes in this PR you will see the following crash:

FATAL EXCEPTION: main
  Process: com.androido, PID: 25946
  android.view.WindowManager$BadTokenException: Unable to add window android.view.ViewRootImpl$W@49e4bdb -- permission denied for window type 2003
      at android.view.ViewRootImpl.setView(ViewRootImpl.java:789)
      at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:356)
      at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:92)
      at android.app.Dialog.show(Dialog.java:330)
      at com.facebook.react.devsupport.DevSupportManagerImpl$4.run(DevSupportManagerImpl.java:356)
      at android.os.Handler.handleCallback(Handler.java:789)
      at android.os.Handler.dispatchMessage(Handler.java:98)
      at android.os.Looper.loop(Looper.java:164)
      at android.app.ActivityThread.main(ActivityThread.java:6541)
      at java.lang.reflect.Method.invoke(Native Method)
      at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

pull-bot · 2017-08-22T11:38:34Z

@facebook-github-bot label Core Team

Generated by 🚫 dangerJS

AndrewJack · 2017-08-22T11:47:08Z

ReactAndroid/src/main/java/com/facebook/react/devsupport/WindowOverlayCompat.java

+class WindowOverlayCompat {
+
+  private static final int ANDROID_OREO = 26;
+  private static final int TYPE_APPLICATION_OVERLAY = 2038;


Cannot use the Android constants because react native doesn't compile to v26 yet, it currently uses v23.

janicduplessis · 2017-08-24T20:08:23Z

ReactAndroid/src/main/java/com/facebook/react/devsupport/WindowOverlayCompat.java

+ * Compatibility wrapper for apps targeting API level 26 or later.
+ * See https://developer.android.com/about/versions/o/android-8.0-changes.html#cwt
+ */
+class WindowOverlayCompat {


I think it could be useful to make this public, if you prefer not to let's just add a /* package */ comment like here for example https://github.com/AndrewJack/react-native/blob/f1cf378cf4ef3e5473fe2ace6d564be897e56a0e/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java#L51

I don't think it needs to be public. It's only needed in the devsupport package and I wouldn't like to encourage app developers to use this either.

I'll add /* package */

janicduplessis · 2017-09-01T22:17:45Z

@shergin Looks good to me if you want to ship.

arpit · 2017-09-09T21:40:05Z

Any update on this? Definitely seeing this crash and the patch looks good. The CI failure seems to be unrelated to this code unless I am missing something

facebook-github-bot · 2017-09-09T22:19:40Z

@shergin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

janicduplessis · 2017-09-11T20:01:47Z

Thanks @AndrewJack for the PR and @shergin for shipping 🎉

Summary: Apps targeting Android 8.0 (API level 26) cannot use `TYPE_SYSTEM_OVERLAY ` and `TYPE_SYSTEM_OVERLAY `. Targeting 26 will cause the app to crash when in `DEV_MODE`. https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt This PR replaces uses of these overlay flags with the new `TYPE_APPLICATION_OVERLAY` when running on a device with Android 8.0 or later. When using `TYPE_APPLICATION_OVERLAY` it still requires the `SYSTEM_ALERT_WINDOW` permission, just like previous android versions. https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY https://github.com/AndrewJack/react-native-android-oreo tested here Closes facebook#15601 Reviewed By: achen1 Differential Revision: D5801619 Pulled By: shergin fbshipit-source-id: 27d1b9bb64018e7f12f9c3d3d222f1fda468b124

Summary: Apps targeting Android 8.0 (API level 26) cannot use `TYPE_SYSTEM_OVERLAY ` and `TYPE_SYSTEM_OVERLAY `. Targeting 26 will cause the app to crash when in `DEV_MODE`. https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt This PR replaces uses of these overlay flags with the new `TYPE_APPLICATION_OVERLAY` when running on a device with Android 8.0 or later. When using `TYPE_APPLICATION_OVERLAY` it still requires the `SYSTEM_ALERT_WINDOW` permission, just like previous android versions. https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY https://github.com/AndrewJack/react-native-android-oreo tested here Closes #15601 Reviewed By: achen1 Differential Revision: D5801619 Pulled By: shergin fbshipit-source-id: 27d1b9bb64018e7f12f9c3d3d222f1fda468b124

Summary: Apps targeting Android 8.0 (API level 26) cannot use `TYPE_SYSTEM_OVERLAY ` and `TYPE_SYSTEM_OVERLAY `. Targeting 26 will cause the app to crash when in `DEV_MODE`. https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt This PR replaces uses of these overlay flags with the new `TYPE_APPLICATION_OVERLAY` when running on a device with Android 8.0 or later. When using `TYPE_APPLICATION_OVERLAY` it still requires the `SYSTEM_ALERT_WINDOW` permission, just like previous android versions. https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY https://github.com/AndrewJack/react-native-android-oreo tested here Closes facebook#15601 Reviewed By: achen1 Differential Revision: D5801619 Pulled By: shergin fbshipit-source-id: 27d1b9bb64018e7f12f9c3d3d222f1fda468b124

rekha110254 · 2017-12-02T04:04:36Z

@AndrewJack @janicduplessis Any update on this?? I'm facing this issue.

FATAL EXCEPTION: main
Process: com.androido, PID: 25946
android.view.WindowManager$BadTokenException: Unable to add window android.view.ViewRootImpl$W@49e4bdb -- permission denied for window type 2003
at android.view.ViewRootImpl.setView(ViewRootImpl.java:789)
at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:356)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:92)
at android.app.Dialog.show(Dialog.java:330)
at com.facebook.react.devsupport.DevSupportManagerImpl$4.run(DevSupportManagerImpl.java:356)
at android.os.Handler.handleCallback(Handler.java:789)
at android.os.Handler.dispatchMessage(Handler.java:98)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6541)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

AndrewJack · 2017-12-02T09:44:24Z

@rekha110254 What version are you using? This was only shipped in RN 0.50.

temitope · 2017-12-23T23:25:10Z

@AndrewJack thanks for this PR, this bug is kicking my project in the shins. I am using RN 0.41 and wondering if there is a recommended way to incorporate this fix outside of 1) upgrading to RN 0.51 and possibly upsetting my other dependencies and 2) manually updating the source files for RN creating an unsupported unique version of the RN codebase just for me :/? Basically I am hoping and wondering if there is a way to just incorporate these changes related to the overlay or do I just need to take the upgrade plunge?
Thanks

zaplo00 · 2018-02-27T14:35:21Z

is navigator.geolocation.getCurrentPosition working in Android 8? Could someone with actual device test it, whether it always returns error 3 (location timeout) or actually works with permission allowed, location services enabled and using both gps and wireless?

rekha110254 · 2018-03-20T15:13:03Z

@AndrewJack RN 0.51.1

Summary: Apps targeting Android 8.0 (API level 26) cannot use `TYPE_SYSTEM_OVERLAY ` and `TYPE_SYSTEM_OVERLAY `. Targeting 26 will cause the app to crash when in `DEV_MODE`. https://developer.android.com/about/versions/oreo/android-8.0-changes.html#cwt This PR replaces uses of these overlay flags with the new `TYPE_APPLICATION_OVERLAY` when running on a device with Android 8.0 or later. When using `TYPE_APPLICATION_OVERLAY` it still requires the `SYSTEM_ALERT_WINDOW` permission, just like previous android versions. https://developer.android.com/reference/android/view/WindowManager.LayoutParams.html#TYPE_APPLICATION_OVERLAY https://github.com/AndrewJack/react-native-android-oreo tested here Closes facebook#15601 Reviewed By: achen1 Differential Revision: D5801619 Pulled By: shergin fbshipit-source-id: 27d1b9bb64018e7f12f9c3d3d222f1fda468b124

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Aug 22, 2017

AndrewJack commented Aug 22, 2017

View reviewed changes

shergin requested a review from janicduplessis August 23, 2017 05:58

hramos added the Core Team label Aug 23, 2017

janicduplessis suggested changes Aug 24, 2017

View reviewed changes

yuki24 mentioned this pull request Aug 26, 2017

Set up Android for emission artsy/emission#730

Closed

iegik mentioned this pull request Aug 28, 2017

RN 0.47 seems to be working fine with gradle 4.0 and compileSdkVersion / buildToolsVersion 26 #15448

Closed

Android Oreo Support

75f4934

janicduplessis approved these changes Sep 1, 2017

View reviewed changes

ide requested a review from shergin September 2, 2017 06:28

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Sep 9, 2017

facebook-github-bot closed this in 96de23a Sep 11, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android Oreo (8.0) Support #15601

Android Oreo (8.0) Support #15601

AndrewJack commented Aug 22, 2017 •

edited

Loading

AndrewJack commented Aug 22, 2017 •

edited

Loading

pull-bot commented Aug 22, 2017 •

edited

Loading

AndrewJack Aug 22, 2017 •

edited

Loading

janicduplessis Aug 24, 2017

AndrewJack Aug 31, 2017 •

edited

Loading

janicduplessis commented Sep 1, 2017

arpit commented Sep 9, 2017

facebook-github-bot commented Sep 9, 2017

janicduplessis commented Sep 11, 2017

rekha110254 commented Dec 2, 2017 •

edited

Loading

AndrewJack commented Dec 2, 2017

temitope commented Dec 23, 2017

zaplo00 commented Feb 27, 2018 •

edited

Loading

rekha110254 commented Mar 20, 2018

Android Oreo (8.0) Support #15601

Android Oreo (8.0) Support #15601

Conversation

AndrewJack commented Aug 22, 2017 • edited Loading

Test Plan

AndrewJack commented Aug 22, 2017 • edited Loading

pull-bot commented Aug 22, 2017 • edited Loading

AndrewJack Aug 22, 2017 • edited Loading

Choose a reason for hiding this comment

janicduplessis Aug 24, 2017

Choose a reason for hiding this comment

AndrewJack Aug 31, 2017 • edited Loading

Choose a reason for hiding this comment

janicduplessis commented Sep 1, 2017

arpit commented Sep 9, 2017

facebook-github-bot commented Sep 9, 2017

janicduplessis commented Sep 11, 2017

rekha110254 commented Dec 2, 2017 • edited Loading

AndrewJack commented Dec 2, 2017

temitope commented Dec 23, 2017

zaplo00 commented Feb 27, 2018 • edited Loading

rekha110254 commented Mar 20, 2018

AndrewJack commented Aug 22, 2017 •

edited

Loading

AndrewJack commented Aug 22, 2017 •

edited

Loading

pull-bot commented Aug 22, 2017 •

edited

Loading

AndrewJack Aug 22, 2017 •

edited

Loading

AndrewJack Aug 31, 2017 •

edited

Loading

rekha110254 commented Dec 2, 2017 •

edited

Loading

zaplo00 commented Feb 27, 2018 •

edited

Loading