Add "- React Native" to all pages title in doc section #15714
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
website/core/Site.js
Outdated
| @@ -26,7 +26,7 @@ class Site extends React.Component { | |||
| var currentYear = new Date().getFullYear(); | |||
|
|
|||
| var title = this.props.title | |||
| ? this.props.title | |||
| ? this.props.title + " - React Native" | |||
There was a problem hiding this comment.
quotes: Strings must use singlequote.
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Thanks for contributing! |
Changing all pages in doc to have title " - React Native", which will make the results easier to distinguish like suggested in issue #15659.
Test Plan
I'm not shure how to write a test to this but if you open any page in doc you can see the page title has changed when the title is passed to Site component.