Update RCTUIManager.m

[iegik]

To make React Native play nicely with our internal build infrastructure we need to properly namespace all of our header includes.

Where previously you could do #import "RCTBridge.h", you must now write this as #import <React/RCTBridge.h>. If your xcode project still has a custom header include path, both variants will likely continue to work, but for new projects, we're defaulting the header include path to $(BUILT_PRODUCTS_DIR)/usr/local/include, where the React and CSSLayout targets will copy a subset of headers too. To make Xcode copy headers phase work properly, you may need to add React as an explicit dependency to your app's scheme and disable "parallelize build".

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

[pull-bot]

Attention: @shergin

Generated by 🚫 dangerJS

[hramos]

Do you have a test plan?

[shergin]

This is a very radical and breaking change which conflicts with established guidelines and practices.
If you are strongly believe that we should reconsider it, please open an issue and provide detailed motivation and strong argumentation there.

[iegik]

Sorry, @shergin, but it was not my opinion. https://github.com/facebook/react-native/releases/tag/v0.40.0

iOS native headers moved

This change affects all native modules and application code on iOS that refer to react native .h files
After e1577df, Native code on iOS must refer to headers out of the react namespace. Previously the following would work:

#import "RCTUtils.h"
But now all headers have been moved:

#import <React/RCTUtils.h>
This means that all iOS native libraries need a major version bump for RN 0.40. We attempt to minimize changes of this magnitude, and we apologize for any inconvenience caused.

[shergin]

That proposal and work is about .h files, not .m or .mm files.
I just want to say that if you want to fight for this, you have to prepare really good arguments and deep and comprehensive analysis of all possible approaches.

[iegik]

I notice, if import file once in with <React/ prefix, next import without prefix cause duplication of declaration error, like now with RCTBridge.h #11725
So, if RCTBridge.h was already imported before in some other module with prefix, and here, in *.m file start to importing without prefix, the compilation cause "duplication error".

Solution:

• Compile React files first
• Create list of all React files and describe how they should be imported
• Revert to 0.39.x version of react and use imports without prefix.
• Fix all imports to imports with <React/ in all files

See also:

• Error: Redefinition of RCTMethodInfo ivpusic/react-native-image-crop-picker#436
• Duplicate RCTMethodInfo zoontek/react-native-permissions#137 (comment)
• Fix importing React/RCTBridgeModule.h zoontek/react-native-permissions#138 (comment)
• Add <React/ prefix to React imports dotintent/react-native-ble-plx#136 (comment)

Also, there is some *.m(m) files with <React/ imports:

• https://github.com/facebook/react-native/blob/master/React/Base/RCTBatchedBridge.mm#L26

[iegik]

@javache , please judge

[iegik]

https://github.com/facebook/react-native/releases/tag/v0.40.0

This change affects all native modules and application code on iOS that refer to react native .h files

After e1577df, Native code on iOS must refer to headers out of the react namespace. Previously the following would work:
#import "RCTUtils.h"
But now all headers have been moved:
#import <React/RCTUtils.h>
This means that all iOS native libraries need a major version bump for RN 0.40. We attempt to minimize changes of this magnitude, and we apologize for any inconvenience caused.

[iegik]

@shergin not only *.h files, but all, that "refer to react native .h files":

all native modules and application code on iOS that refer to react native .h files