[ListView] Update curRenderedRowsCount when data source changes #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new data source is provided, update `curRenderedRowsCount` in addition to `prevRenderedRowsCount`. What was happening is that I had an empty data source, so `curRenderedRowsCount` and `prevRenderedRowsCount` both settled at zero after the first few frames and `curRenderedRowsCount` wasn't getting increased when the data source was updated. I also changed the `setState` calls to use the transactional API since several of the new state values are computed from the old ones.
facebook-github-bot
added
the
CLA Signed
Fanghao
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 22, 2015
Summary: When a new data source is provided, update `curRenderedRowsCount` in addition to `prevRenderedRowsCount`. What was happening is that I had an empty data source, so `curRenderedRowsCount` and `prevRenderedRowsCount` both settled at zero after the first few frames and `curRenderedRowsCount` wasn't getting increased when the data source was updated. I also changed the `setState` calls to use the transactional API since several of the new state values are computed from the old ones. Maybe fixes facebook#1547 Closes facebook#1612 Github Author: James Ide <ide@jameside.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new data source is provided, update
curRenderedRowsCountin addition toprevRenderedRowsCount. What was happening is that I had an empty data source, socurRenderedRowsCountandprevRenderedRowsCountboth settled at zero after the first few frames andcurRenderedRowsCountwasn't getting increased when the data source was updated.I also changed the
setStatecalls to use the transactional API since several of the new state values are computed from the old ones.Maybe fixes #1547