Fix reference to fishhook.h in RCTReconnectingWebSocket.m #16130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When upgrading to react-native 0.49 you get an error due to a reference to
fishhook.h
inRCTReconnectingWebSocket.m
. When I read the fishhook docs it specified that when thefishhook.a
binary is linked references should be imported as:Link to issue: #16039
https://github.com/facebook/react-native/blob/master/Libraries/fishhook/README.md
Test Plan
Upgrade from a clean react-native 0.48 to 0.49, upgrade your podspec to include fishhook.
Run the project and it should fail on this import.