[BUGFIX] Requesting permission results into ArrayIndexOutOfBoundsException #16507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndsException - Issue 15928 * TestPlan: Uses existing code in android test folder * Motivation: Fixing when asked for permission -> press home button -> open the App again (via shortcut). Will causes ArrayIndexOutOfBounds.
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 24, 2017
There was a problem hiding this comment.
@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
elgambet
pushed a commit
to khemlabs/react-native
that referenced
this pull request
May 20, 2018
Summary: Reported in Issue facebook#15928 Fixing bug when permission showing dialog and user go to home and re-open minimized app. 1. Ask for permission 2. Minimize app (Press HomeButton) 3. Open app again via shortcut [ANDROID] [BUGFIX] [PermissionsModule.java] - Fixed bug when asked for permission Cause: java.lang.ArrayIndexOutOfBoundsException · length=0; index=0 Closes facebook#16507 Differential Revision: D6133708 Pulled By: shergin fbshipit-source-id: 9c05d1d5d16fedf718ad5113df69a4df3af62013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in Issue #15928
Motivation
Fixing bug when permission showing dialog and user go to home and re-open minimized app.
Test Plan
Release Notes
[ANDROID] [BUGFIX] [PermissionsModule.java] - Fixed bug when asked for permission Cause: java.lang.ArrayIndexOutOfBoundsException · length=0; index=0