Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Executor] Make executor ID functions non-static to fix ASan #1712

Closed
wants to merge 1 commit into from
Closed

[Executor] Make executor ID functions non-static to fix ASan #1712

wants to merge 1 commit into from

Commits on Jun 22, 2015

  1. [Executor] Make executor ID functions non-static to fix ASan 

    When `RCTGetExecutorID` was a static function in the header file, it would return nil when the app was running with ASan enabled even though directly calling `objc_getAssociatedObject(executor, RCTJavaScriptExecutorID)` returned the correct ID as an NSNumber. Moving this function into the .m file fixes this issue.

Test Plan: Run the UIExplorer with ASan enabled in Xcode 7. Before this diff, the app would just hang since the executor was unable to read a valid ID and so it would bail out from running JS. With this diff the executor runs the JS and the UIExplorer works fine.
    @ide
    ide committed Jun 22, 2015
    Configuration menu
    Copy the full SHA
    e4fbd24 View commit details
    Browse the repository at this point in the history