Link both iOS and tvOS libraries with react-native link (fix #13783) #17231

douglowder · 2017-12-15T22:11:24Z

Motivation

Fix issues with the react-native CLI when linking iOS and tvOS libraries to a project created with react-native init. (#13783)

Test Plan

Verified the changes against test project at https://github.com/dlowder-salesforce/react-native-link-test. Both react-native link react-native-svg and react-native unlink react-native-svg work correctly on this project. Added new unit test for the new file added to local-cli/link/ios.

Release Notes

[CLI] [BUGFIX] react-native link has been fixed to correctly link iOS and tvOS targets.
[IOS] [BUGFIX] react-native link has been fixed to correctly link iOS and tvOS targets.

douglowder · 2017-12-15T22:12:40Z

@grabbou please review this when you get a chance.

pull-bot · 2017-12-15T22:12:40Z

	Warnings
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Attention: @shergin

Generated by 🚫 dangerJS

eslint-bot · 2017-12-15T22:13:08Z

local-cli/link/ios/getTargets.js

+ * Given xcodeproj it returns list of targets
+ */
+module.exports = function getTargets(project) {
+  let targets = project.getFirstProject()['firstProject']['targets'];


dot-notation: ["firstProject"] is better written in dot notation.

eslint-bot · 2017-12-15T22:13:08Z

local-cli/link/ios/getTargets.js

+ * Given xcodeproj it returns list of targets
+ */
+module.exports = function getTargets(project) {
+  let targets = project.getFirstProject()['firstProject']['targets'];


dot-notation: ["targets"] is better written in dot notation.

pull-bot · 2017-12-27T23:42:42Z

	Warnings
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Attention: @shergin

Generated by 🚫 dangerJS

douglowder · 2017-12-31T07:07:21Z

@grabbou could you please review this ASAP?

grabbou · 2018-01-04T16:13:51Z

Have this on my TODO list after Christmas. I am back today to work, will be taking care of this this week.

…

On Sun, 31 Dec 2017 at 08:08 Douglas Lowder ***@***.***> wrote: @grabbou <https://github.com/grabbou> could you please review this ASAP? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17231 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWcxklrPou4-D-_AU3j38C5gkpBNSLYks5tFzLqgaJpZM4RED26> .

douglowder · 2018-01-16T18:55:57Z

@grabbou : @matthargett says this looks good, but is asking for automated testing of react-native link and react-native unlink with these changes. I'll go ahead and start working on that.... it's up to you whether you want to go ahead and merge this, given the severity of the bug.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

hramos · 2018-01-29T21:48:48Z

If this does not land shortly, please try re-basing. Due to a recent change to the internal repo, some PRs older than a week (as of today) may need to be rebased in order to land cleanly.

hramos

Please rebase and we can try re-importing again.

douglowder · 2018-01-30T18:51:38Z

@hramos I just merged from facebook/master, hopefully it can be landed now... Thanks!!

douglowder · 2018-01-30T19:06:47Z

@hramos after the last merge from master, I'm hitting #17742 when I test this locally... FYI

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

…#13783) Summary: Fix issues with the react-native CLI when linking iOS and tvOS libraries to a project created with `react-native init`. (facebook#13783) Verified the changes against test project at https://github.com/dlowder-salesforce/react-native-link-test. Both `react-native link react-native-svg` and `react-native unlink react-native-svg` work correctly on this project. Added new unit test for the new file added to `local-cli/link/ios`. [CLI] [BUGFIX] `react-native link` has been fixed to correctly link iOS and tvOS targets. [IOS] [BUGFIX] `react-native link` has been fixed to correctly link iOS and tvOS targets. Closes facebook#17231 Differential Revision: D6837567 Pulled By: hramos fbshipit-source-id: 234d3d3966ae1b89cd16a37c95d303553f7ba5f5

Summary: Fix issues with the react-native CLI when linking iOS and tvOS libraries to a project created with `react-native init`. (#13783) Verified the changes against test project at https://github.com/dlowder-salesforce/react-native-link-test. Both `react-native link react-native-svg` and `react-native unlink react-native-svg` work correctly on this project. Added new unit test for the new file added to `local-cli/link/ios`. [CLI] [BUGFIX] `react-native link` has been fixed to correctly link iOS and tvOS targets. [IOS] [BUGFIX] `react-native link` has been fixed to correctly link iOS and tvOS targets. Closes facebook/react-native#17231 Differential Revision: D6837567 Pulled By: hramos fbshipit-source-id: 234d3d3966ae1b89cd16a37c95d303553f7ba5f5

Fix for react-native link with tvOS libraries

39ece59

douglowder mentioned this pull request Dec 15, 2017

Link both iOS and tvOS libraries with react-native link (fix #13783) #17084

Closed

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 15, 2017

eslint-bot reviewed Dec 15, 2017

View reviewed changes

Fix breaking tvOS compile issues with RCTRedBoxExtraDataViewController.m

829735a

douglowder requested a review from shergin as a code owner December 15, 2017 22:26

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

4985254

douglowder added 2 commits December 30, 2017 22:57

Fix ESLint issue

1f7d760

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

fb01596

douglowder mentioned this pull request Dec 31, 2017

xcodebuild warning in 0.48.3: The file reference for "libReact-tvOS.a" is a member of multiple groups ("Products" and "Products") #16061

Closed

douglowder added 2 commits January 10, 2018 09:50

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

1d72c33

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

fcf18de

matthargett approved these changes Jan 15, 2018

View reviewed changes

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

93adb63

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 29, 2018

facebook-github-bot approved these changes Jan 29, 2018

View reviewed changes

hramos suggested changes Jan 29, 2018

View reviewed changes

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

1f70785

douglowder added 2 commits January 30, 2018 12:02

Fix tvOS build breakage (RCTUIUtils.m)

3a76c94

Merge remote-tracking branch 'upstream/master' into tvos-cli-link-fix-2

0b50ff8

douglowder and others added 4 commits January 30, 2018 13:11

@Remitly temp fix for facebook#17742

e048bf1

New reference images for tvOS

f4ebb1a

Fix flow error

74dff43

Undo temporary workaround

823a6b4

facebook-github-bot approved these changes Jan 30, 2018

View reviewed changes

facebook-github-bot closed this in a63fd37 Jan 31, 2018

douglowder mentioned this pull request Apr 6, 2018

Custom fonts won't load on tvOS apps - Unrecognized font family #18025

Closed

douglowder deleted the tvos-cli-link-fix-2 branch April 6, 2018 18:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Link both iOS and tvOS libraries with react-native link (fix #13783) #17231

Link both iOS and tvOS libraries with react-native link (fix #13783) #17231

douglowder commented Dec 15, 2017

douglowder commented Dec 15, 2017

pull-bot commented Dec 15, 2017 •

edited

Loading

eslint-bot Dec 15, 2017

eslint-bot Dec 15, 2017

pull-bot commented Dec 27, 2017 •

edited

Loading

douglowder commented Dec 31, 2017

grabbou commented Jan 4, 2018 via email

douglowder commented Jan 16, 2018

facebook-github-bot left a comment

hramos commented Jan 29, 2018

hramos left a comment

douglowder commented Jan 30, 2018

douglowder commented Jan 30, 2018

facebook-github-bot left a comment

facebook-github-bot left a comment

Link both iOS and tvOS libraries with react-native link (fix #13783) #17231

Link both iOS and tvOS libraries with react-native link (fix #13783) #17231

Conversation

douglowder commented Dec 15, 2017

Motivation

Test Plan

Release Notes

douglowder commented Dec 15, 2017

pull-bot commented Dec 15, 2017 • edited Loading

eslint-bot Dec 15, 2017

Choose a reason for hiding this comment

eslint-bot Dec 15, 2017

Choose a reason for hiding this comment

pull-bot commented Dec 27, 2017 • edited Loading

douglowder commented Dec 31, 2017

grabbou commented Jan 4, 2018 via email

douglowder commented Jan 16, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

hramos commented Jan 29, 2018

hramos left a comment

Choose a reason for hiding this comment

douglowder commented Jan 30, 2018

douglowder commented Jan 30, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

pull-bot commented Dec 15, 2017 •

edited

Loading

pull-bot commented Dec 27, 2017 •

edited

Loading