Fix Xcode Archive task failing if project path contains whitespace

[jevakallio]

Motivation

Currently, Xcodebuild Archive task "Bundle React Native code and images" step fails if the project path contains whitespace characters. This is due to react-native-xcode.sh not escaping the local CLI path.

Ideally, of course, folks would use sane directory names, but this affects people in the community. I have seen this at a beginner hackathon, as well as Stack Overflow, e.g. https://stackoverflow.com/questions/48209829/cannot-create-offline-bundle-for-react-native-ios

Test Plan

Verify build is currently broken

mkdir Bad\ Name
cd Bad\ Name
react-native init TestProject
cd TestProject
open ios/TestProject.xcodeproj

• Run Build > Archive
• cli.js bundle command fails with "Cannot find module '.../Bad'"

Verify fix works

• Patch /node_modules/react-native/scripts/react-native-xcode.sh with changed file
• Run Build > Archive
• Build succeeds

Release Notes

[IOS] [MINOR] [scripts/react-native-xcode.sh] - Escape directory paths with spaces

[pull-bot]

@facebook-github-bot label Android

Generated by 🚫 dangerJS

[facebook-github-bot]

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[hramos]

A rebase is needed due to some changes that happened earlier this week in our internal monorepo outside of the synced react-native directory (but nonetheless prevent this PR from landing). Simply hitting Update branch should resolve it, let's see.

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.