DX: log full js errors instead of just error messages (ExceptionsManager) #17771
Conversation
@facebook-github-bot label Needs more information Generated by 🚫 dangerJS |
facebook-github-bot
added
CLA Signed
slorber
changed the title
|
@slorber I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
react-native-bot
added
Missing Changelog
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
not sure this actually solves the problem, I'm closing as I don't really know how to solve it anyway |
Motivation
This is really annoying DX to not have full stacktrace of errors in Chrome developer tools.
This kind of error is totally unactionnable without deeper debugging, as we don't have a single stacktrace, while it could be made actionnable easily
Some issues already have been opened regarding this problem, yet they did not get much attention and got closed by stale bot.
#16661
#16205
Test Plan
Errors are logged appropriately in Chrome developer tools with full stacktrace
Release Notes
[ENHANCEMENT][MINOR][ExceptionsManager.js] Log full errors instead of just error messages
Other
I must admin I may not see all the implications of why the message did got logged instead of the full exception in the first place.
If you know why and there's a good reason, please tell me and we can probably do something better than current state to help people debug RN apps.