add x86_64 arm64-v8a support. Fixes #2814 #18754

gengjiawen · 2018-04-08T12:47:24Z

Motivaion

add arm64 support, related issue : #2814.
If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release.

Test Plan

RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta.

Related PRs

facebookarchive/android-jsc#30.

Release Notes

[ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support.

hwangjr · 2018-05-05T15:57:12Z

any progress about this support?

gengjiawen · 2018-05-11T02:02:03Z

@hramos Can you help on this ?

hramos · 2018-05-14T16:59:05Z

I'm not the right person to review this, sorry.

hwangjr · 2018-05-15T10:37:02Z

@hramos maybe you know the right person?

hramos · 2018-06-15T17:01:38Z

@mdvacca

gengjiawen · 2018-06-16T00:08:49Z

@hramos Why push commit to this pr. If we the new jsc is using internal by facebook, this #19536 is pr I more prefered.

gengjiawen · 2018-08-19T07:39:17Z

@mdvacca Any thought to merge this or wait for user-specific jsc support ?

gengjiawen · 2018-08-21T14:27:08Z

We have been stuck with #2814 too long, maybe merge this first.

facebook-github-bot

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

gengjiawen · 2018-09-22T07:12:32Z

Looks like take too long to import. @hramos

CoreFloDev · 2018-09-22T10:04:22Z

One quick question about this. How can we guaranty that there is no keylogger or bitcoin mining program inside the binary and it is doing only what it is suppose to do?

gengjiawen · 2018-09-22T10:24:42Z

get the so to any virus scan software or push fb to merge my pr to android-jsc.

hramos · 2018-09-24T17:35:48Z

The import failed due to a binary size limit. I've whitelisted the PR and I am trying to land this again. Please do not add any commits, to ensure the land is not cancelled.

Summary: add arm64 support, related issue : #2814. If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release. RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta. facebookarchive/android-jsc#30. [ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support. Differential Revision: D9491481 Pulled By: hramos fbshipit-source-id: d6ec6992768eb0c0866a0317273e09fae5b8935e

RSNara · 2018-09-27T17:19:25Z

@gengjiawen. So I generate a new project using react-native init. When I try to run the android version of the generated project, it insta-crashes after metro sends the bundle over. Here's the error that adb logcat logs:

09-27 08:37:10.889 16947 17028 D SoLoader: About to load: libreactnativejni.so
09-27 08:37:10.890 16947 17028 D SoLoader: libreactnativejni.so found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.897 16947 17028 D SoLoader: Loading lib dependencies: [libglog_init.so, libyoga.so, libprivatedata.so, libfb.so, libfolly_json.so, libjsc.so, libglog.so, libgnustl_shared.so, libandroid.so, liblog.so, libstdc++.so, libm.so, libc.so, libdl.so]
09-27 08:37:10.897 16947 17028 D SoLoader: About to load: libglog_init.so
09-27 08:37:10.898 16947 17028 D SoLoader: libglog_init.so found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.898 16947 17028 D SoLoader: Loading lib dependencies: [libglog.so, libgnustl_shared.so, liblog.so, libstdc++.so, libm.so, libc.so, libdl.so]
09-27 08:37:10.899 16947 17028 D SoLoader: About to load: libglog.so
09-27 08:37:10.899 16947 17028 D SoLoader: libglog.so found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.901 16947 17028 D SoLoader: Loading lib dependencies: [libgnustl_shared.so, libstdc++.so, libm.so, libc.so, libdl.so]
09-27 08:37:10.901 16947 17028 D SoLoader: About to load: libgnustl_shared.so
09-27 08:37:10.901 16947 17028 D SoLoader: libgnustl_shared.so found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.902 16947 17028 D SoLoader: Loading lib dependencies: [libm.so, libc.so, libdl.so]
09-27 08:37:10.902 16947 17028 D SoLoader: About to load: libm.so
09-27 08:37:10.903 16947 17028 D SoLoader: libm.so not found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.903 16947 17028 D SoLoader: libm.so not found on /data/app/com.rnapp1538062456-1/lib/x86_64
09-27 08:37:10.903 16947 17028 D SoLoader: libm.so not found on /system/vendor/lib
09-27 08:37:10.903 16947 17028 D SoLoader: libm.so found on /system/lib
09-27 08:37:10.903 16947 17028 D SoLoader: libm.so loaded implicitly
09-27 08:37:10.903 16947 17028 D SoLoader: Loaded: libm.so
09-27 08:37:10.903 16947 17028 D SoLoader: About to load: libc.so
09-27 08:37:10.903 16947 17028 D SoLoader: libc.so not found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.903 16947 17028 D SoLoader: libc.so not found on /data/app/com.rnapp1538062456-1/lib/x86_64
09-27 08:37:10.903 16947 17028 D SoLoader: libc.so not found on /system/vendor/lib
09-27 08:37:10.904 16947 17028 D SoLoader: libc.so found on /system/lib
09-27 08:37:10.904 16947 17028 D SoLoader: libc.so loaded implicitly
09-27 08:37:10.904 16947 17028 D SoLoader: Loaded: libc.so
09-27 08:37:10.904 16947 17028 D SoLoader: About to load: libdl.so
09-27 08:37:10.904 16947 17028 D SoLoader: libdl.so not found on /data/data/com.rnapp1538062456/lib-main
09-27 08:37:10.904 16947 17028 D SoLoader: libdl.so not found on /data/app/com.rnapp1538062456-1/lib/x86_64
09-27 08:37:10.904 16947 17028 D SoLoader: libdl.so not found on /system/vendor/lib
09-27 08:37:10.904 16947 17028 D SoLoader: libdl.so found on /system/lib
09-27 08:37:10.904 16947 17028 D SoLoader: libdl.so loaded implicitly
09-27 08:37:10.904 16947 17028 D SoLoader: Loaded: libdl.so
09-27 08:37:10.910 16947 17028 E SoLoader: Error when loading lib: dlopen failed: "/data/data/com.rnapp1538062456/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit lib hash: 38099cfdfc816f823cb69c5387381ddd search path is /data/app/com.rnapp1538062456-1/lib/x86_64
09-27 08:37:10.910 16947 17028 E SoLoader: couldn't find DSO to load: libgnustl_shared.so caused by: dlopen failed: "/data/data/com.rnapp1538062456/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit
09-27 08:37:10.910 16947 17028 E SoLoader: couldn't find DSO to load: libglog.so caused by: couldn't find DSO to load: libgnustl_shared.so caused by: dlopen failed: "/data/data/com.rnapp1538062456/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit
09-27 08:37:10.910 16947 17028 E SoLoader: couldn't find DSO to load: libglog_init.so caused by: couldn't find DSO to load: libglog.so caused by: couldn't find DSO to load: libgnustl_shared.so caused by: dlopen failed: "/data/data/com.rnapp1538062456/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit
09-27 08:37:10.910 16947 17028 E SoLoader: couldn't find DSO to load: libreactnativejni.so caused by: couldn't find DSO to load: libglog_init.so caused by: couldn't find DSO to load: libglog.so caused by: couldn't find DSO to load: libgnustl_shared.so caused by: dlopen failed: "/data/data/com.rnapp1538062456/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit
09-27 08:37:10.910 16947 17028 E AndroidRuntime: FATAL EXCEPTION: Thread-2
09-27 08:37:10.910 16947 17028 E AndroidRuntime: Process: com.rnapp1538062456, PID: 16947
09-27 08:37:10.910 16947 17028 E AndroidRuntime: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libreactnativejni.so caused by: couldn't find DSO to load: libglog_init.so caused by: couldn't find DSO to load: libglog.so caused by: couldn't find DSO to load: libgnustl_shared.so caused by: dlopen failed: "/data/data/com.rnapp1538062456/lib-main/libgnustl_shared.so" is 32-bit instead of 64-bit
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:703)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:564)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:500)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:455)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.react.bridge.ReactBridge.staticInit(ReactBridge.java:18)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.react.bridge.NativeMap.<clinit>(NativeMap.java:19)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.react.bridge.JSCJavaScriptExecutorFactory.create(JSCJavaScriptExecutorFactory.java:21)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:914)
09-27 08:37:10.910 16947 17028 E AndroidRuntime: 	at java.lang.Thread.run(Thread.java:761)
09-27 08:37:10.922  1617  2151 W ActivityManager:   Force finishing activity com.rnapp1538062456/.MainActivity
09-27 08:37:10.954  1313  2102 D gralloc_ranchu: gralloc_alloc: Creating ashmem region of size 2691072

Pretty sure this commit is the problem since its parent works fine, but this commit doesn't. Are you familiar with what could have caused this problem, @gengjiawen?

gengjiawen · 2018-09-27T22:40:09Z

what device are you running ? Is it a x86_64 emulator ?

kelset · 2018-09-28T08:50:07Z

@RSNara did you pass some custom parameters to react-native init? Because I don't think this commit is available in any release yet (current latest 0.57.1) 🤔

RSNara · 2018-09-28T14:58:40Z

@kelset I used node react-native-cli/index.js init <app-name> to generate the project.

@gengjiawen It's a x86_64 emulator. Here are the details (from IntelliJ):

Name: fb_default_emulator
CPU/ABI: Google APIs Intel Atom (x86_64)
Path: /Users/ramanpreet/.android/avd/fb_default_emulator.avd
Target: google_apis [Google APIs] (API level 24)
SD Card: 1000M
hw.dPad: no
hw.lcd.height: 1920
hw.accelerometer: yes
hw.device.name: Nexus 5X
hw.device.manufacturer: Google
hw.lcd.width: 1080
hw.gps: yes
image.androidVersion.api: 24
hw.audioInput: yes
image.sysdir.1: system-images/android-24/google_apis/x86_64/
tag.id: google_apis
hw.mainKeys: no
hw.lcd.density: 420
hw.device.hash2: MD5:bc5032b2a871da511332401af3ac6bb0
hw.trackBall: no
PlayStore.enabled: false
hw.battery: yes
hw.sdCard: yes
tag.display: Google APIs
hw.keyboard: yes
hw.sensors.proximity: yes
hw.sensors.orientation: yes
avd.ini.encoding: UTF-8

gengjiawen · 2018-09-28T15:09:37Z

I doesn't put x86_64 abi in template, only in RNTester. Normally from my experience a x86 emulator is sufficient.

RSNara · 2018-09-28T16:46:45Z

@gengjiawen, I'm not sure I follow your comment. What concrete steps can we take to fix this?

gengjiawen · 2018-09-28T23:30:09Z

If you want to run this on x86_64 emulator, add x86_64 to this line https://github.com/facebook/react-native/blob/master/local-cli/templates/HelloWorld/android/app/build.gradle#L112.

RSNara · 2018-10-03T00:08:01Z

@gengjiawen, I just added x86_64 to that line and rebuilt a starter project, and still no luck. Should making that change be sufficient to get the android starter working?

gengjiawen · 2018-10-03T01:06:02Z

@RSNara Can you try RNTester on that emulator ?

RSNara · 2018-10-03T16:31:22Z

@gengjiawen RNTester works fine.

In case you're curious, here's the script I'm using to create a react native project:

#/bin/bash

set -e

APP_NAME=rnapp$(date +%s)
RN_GITUB=~/fbsource/xplat/js/react-native-github

echo 'Installing dependencies...'
cd $RN_GITHUB
npm install prompt
echo ''

echo 'Temporarily modify local files'
sed -i '' "s/execSync(installCommand/execSync('yarn link react-native'/g" $RN_GITHUB/react-native-cli/index.js
sed -i '' "s|ReactNativeVersionCheck.checkVersions();|// ReactNativeVersionCheck.checkVersions();|g" $RN_GITHUB/Libraries/Core/InitializeCore.js
echo ''

echo 'Link react-native'
yarn link
echo ''

echo "Create react-native app: $APP_NAME"
node ./react-native-cli/index.js init $APP_NAME
cd $APP_NAME && npm install react-native
echo ''

echo "Copy source files into \"$APP_NAME\""
cp -r ../{React,ReactAndroid,ReactCommon,Libraries} ./node_modules/react-native
echo ''

echo "Move \"$APP_NAME\" to desktop"
cd .. && mv $APP_NAME ~/Desktop/$APP_NAME
echo ''

echo "Undo file modifications"
sed -i '' "s/execSync('yarn link react-native'/execSync(installCommand/g" $RN_GITHUB/react-native-cli/index.js
sed -i '' "s|// ReactNativeVersionCheck.checkVersions();|ReactNativeVersionCheck.checkVersions();|g" $RN_GITHUB/Libraries/Core/InitializeCore.js
echo ''

echo "Generated app: $APP_NAME"
echo "Run \"cd ~/Desktop/$APP_NAME\" to get to app"
echo 'Run "yarn start" to start metro'
echo 'Run "yarn android" to install to a running android emulator'
echo 'Run "yarn ios" to open up and install to an ios emulator'

gengjiawen · 2018-10-03T16:42:33Z

Can you check the so in the generated apk using android studio ?

…8754)" This reverts commit 0a2825f.

Summary: add arm64 support, related issue : facebook#2814. If we are okay with binary aar android-jsc, then the pr can be directly merged. Otherwise merge facebookarchive/android-jsc#30 first and do a new release. RNTester all variant works. You can also test the apk from here: https://github.com/gengjiawen/react-native/releases/tag/v0.56beta. facebookarchive/android-jsc#30. [ANDROID] [ENHANCEMENT] [ABI] - add x86_64 arm64-v8a support. Differential Revision: D9491481 Pulled By: hramos fbshipit-source-id: d6ec6992768eb0c0866a0317273e09fae5b8935e

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2018

react-native-bot added the 📋Release Notes label Apr 8, 2018

gengjiawen mentioned this pull request Apr 9, 2018

Support third-party 64-bit libraries on Android #2814

Closed

gengjiawen changed the title ~~[WIP]Feature/x64 support~~ add arm64 and x86_64 support Apr 9, 2018

gengjiawen force-pushed the feature/x64_support branch from b617f49 to 668204c Compare April 10, 2018 03:06

This comment has been minimized.

Sign in to view

marafat mentioned this pull request Jun 1, 2018

Build 64bit binaries for Android #19536

Closed

gengjiawen force-pushed the feature/x64_support branch from 668204c to fc3ea39 Compare June 13, 2018 04:07

kelset mentioned this pull request Jun 15, 2018

[META] Upgrading JSC #19737

Closed

hramos added the Platform: Android Android applications. label Jun 15, 2018

This comment has been minimized.

Sign in to view

hramos added the Core Team label Jul 24, 2018

gengjiawen force-pushed the feature/x64_support branch from f5e579d to cba56df Compare August 18, 2018 14:50

gengjiawen requested a review from foghina August 19, 2018 08:10

gengjiawen mentioned this pull request Aug 21, 2018

[META] Roadmap of future Android(s) #19297

Closed

13 tasks

gengjiawen changed the title ~~add arm64 and x86_64 support~~ Fixes #2814 Aug 21, 2018

gengjiawen requested review from ide, passy, elicwhite, yungsters and hramos August 21, 2018 14:33

hramos changed the title ~~Fixes #2814~~ Add arm64 support Aug 21, 2018

facebook-github-bot approved these changes Sep 17, 2018

View reviewed changes

hramos closed this Sep 24, 2018

hramos mentioned this pull request Sep 24, 2018

Add arm64 x86_64 support facebookarchive/android-jsc#30

Closed

hramos added this to the 0.58 RC milestone Sep 25, 2018

janicduplessis added a commit to janicduplessis/react-native that referenced this pull request Oct 13, 2018

Revert "add x86_64 arm64-v8a support. Fixes facebook#2814 (facebook#1…

9cc788e

…8754)" This reverts commit 0a2825f.

Kudo mentioned this pull request Oct 19, 2018

[META] Upgrading Folly #20302

Closed

hey99xx mentioned this pull request Nov 1, 2018

[ANDROID] [ENHANCEMENT] [build] - Use clang to build Android libraries #21863

Closed

1 task

janicduplessis added a commit to janicduplessis/react-native that referenced this pull request Nov 3, 2018

Revert "add x86_64 arm64-v8a support. Fixes facebook#2814 (facebook#1…

7bfccf9

…8754)" This reverts commit 0a2825f.

Kudo mentioned this pull request Nov 14, 2018

Raise out android-jsc issues in current master #22274

Closed

3 tasks

kmagiera added a commit to kmagiera/react-native that referenced this pull request Nov 15, 2018

Revert "add x86_64 arm64-v8a support. Fixes facebook#2814 (facebook#1…

186571d

…8754)" This reverts commit 0a2825f.

kneth mentioned this pull request Jan 16, 2019

[React Native] Add 64 bit support for Android realm/realm-js#2221

Closed

hramos removed the Import Failed label Mar 8, 2019

hey99xx mentioned this pull request Jun 27, 2019

"What do you dislike about React Native?" June 2019 Edition react-native-community/discussions-and-proposals#134

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add x86_64 arm64-v8a support. Fixes #2814 #18754

add x86_64 arm64-v8a support. Fixes #2814 #18754

gengjiawen commented Apr 8, 2018 •

edited

Loading

hwangjr commented May 5, 2018

This comment has been minimized.

gengjiawen commented May 11, 2018

hramos commented May 14, 2018

hwangjr commented May 15, 2018

hramos commented Jun 15, 2018

gengjiawen commented Jun 16, 2018 •

edited

Loading

This comment has been minimized.

gengjiawen commented Aug 19, 2018

gengjiawen commented Aug 21, 2018

facebook-github-bot left a comment

gengjiawen commented Sep 22, 2018

CoreFloDev commented Sep 22, 2018

gengjiawen commented Sep 22, 2018

hramos commented Sep 24, 2018

RSNara commented Sep 27, 2018 •

edited

Loading

gengjiawen commented Sep 27, 2018

kelset commented Sep 28, 2018

RSNara commented Sep 28, 2018 •

edited

Loading

gengjiawen commented Sep 28, 2018

RSNara commented Sep 28, 2018

gengjiawen commented Sep 28, 2018

RSNara commented Oct 3, 2018

gengjiawen commented Oct 3, 2018

RSNara commented Oct 3, 2018 •

edited

Loading

gengjiawen commented Oct 3, 2018

add x86_64 arm64-v8a support. Fixes #2814 #18754

add x86_64 arm64-v8a support. Fixes #2814 #18754

Conversation

gengjiawen commented Apr 8, 2018 • edited Loading

Motivaion

Test Plan

Related PRs

Release Notes

hwangjr commented May 5, 2018

This comment has been minimized.

gengjiawen commented May 11, 2018

hramos commented May 14, 2018

hwangjr commented May 15, 2018

hramos commented Jun 15, 2018

gengjiawen commented Jun 16, 2018 • edited Loading

This comment has been minimized.

gengjiawen commented Aug 19, 2018

gengjiawen commented Aug 21, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

gengjiawen commented Sep 22, 2018

CoreFloDev commented Sep 22, 2018

gengjiawen commented Sep 22, 2018

hramos commented Sep 24, 2018

RSNara commented Sep 27, 2018 • edited Loading

gengjiawen commented Sep 27, 2018

kelset commented Sep 28, 2018

RSNara commented Sep 28, 2018 • edited Loading

gengjiawen commented Sep 28, 2018

RSNara commented Sep 28, 2018

gengjiawen commented Sep 28, 2018

RSNara commented Oct 3, 2018

gengjiawen commented Oct 3, 2018

RSNara commented Oct 3, 2018 • edited Loading

gengjiawen commented Oct 3, 2018

gengjiawen commented Apr 8, 2018 •

edited

Loading

gengjiawen commented Jun 16, 2018 •

edited

Loading

RSNara commented Sep 27, 2018 •

edited

Loading

RSNara commented Sep 28, 2018 •

edited

Loading

RSNara commented Oct 3, 2018 •

edited

Loading