Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CocoaPods integration without DevSupport subspec #19265

Closed
wants to merge 1 commit into from
Closed

Fix CocoaPods integration without DevSupport subspec #19265

wants to merge 1 commit into from

Conversation

ikesyo
Copy link
Contributor

@ikesyo ikesyo commented May 15, 2018

This is the thing which is handled in https://github.com/orta/cocoapods-fix-react-native today.

https://github.com/orta/cocoapods-fix-react-native/blob/89a78ad34950b5d6b3de657914c8ced8bf37ee8e/lib/cocoapods-fix-react-native/versions/0_55_3-post.rb#L140-L164

This should be the correct fix for #17799.

Test Plan

Integrating React Native into an existing iOS project using CocoaPods without DevSupport subspec and seeing if the project successfully compiles.

Release Notes

[IOS] [BUGFIX] [DevSupport] - Fix CocoaPods integration without DevSupport subspec

@ikesyo ikesyo requested a review from shergin as a code owner May 15, 2018 09:24
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2018
@ikesyo
Copy link
Contributor Author

ikesyo commented May 15, 2018

I think this should also be backported to 0.55-stable branch.

@hramos
Copy link
Contributor

hramos commented May 15, 2018

0.55 has been out for a while, this can probably wait for 0.56, but best to discuss over in https://github.com/react-native-community/react-native-releases

@ikesyo ikesyo force-pushed the conditional-import-RCTPackagerClient branch 2 times, most recently from b397bcf to 4e70d62 Compare May 17, 2018 10:31
@ikesyo
Copy link
Contributor Author

ikesyo commented May 17, 2018

What should I do for the test failures? Those are apparently unrelated to the changes in this PR.

@ikesyo
Copy link
Contributor Author

ikesyo commented May 23, 2018

Could you please review this, maintainers?

@ikesyo ikesyo force-pushed the conditional-import-RCTPackagerClient branch from 4e70d62 to ed6b8ff Compare May 24, 2018 01:15
@hramos
Copy link
Contributor

hramos commented May 24, 2018

@orta, can you take a look at this PR?

@orta
Copy link
Contributor

orta commented May 24, 2018

Yep, this PR does what I'd expect it to - moving some of the headers and imports to be hidden behind compiler flags that are only set when the dev web socket is included 👍

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label May 24, 2018
facebook-github-bot
facebook-github-bot approved these changes May 24, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@orta
Copy link
Contributor

orta commented May 24, 2018

Also, want to emphasize that you can always ping me on any of these kind of issues 👍

@ikesyo
Copy link
Contributor Author

ikesyo commented May 24, 2018

Thanks @orta!

@ikesyo ikesyo deleted the conditional-import-RCTPackagerClient branch May 25, 2018 02:14
@devpascoe devpascoe mentioned this pull request May 31, 2018
Open
@hramos hramos mentioned this pull request Jun 12, 2018
Closed
1 task
macdoum1 pushed a commit to macdoum1/react-native that referenced this pull request Jun 28, 2018
@ikesyo @macdoum1
Fix CocoaPods integration without DevSupport subspec
4eb6608 
Summary:
This is the thing which is handled in https://github.com/orta/cocoapods-fix-react-native today.

https://github.com/orta/cocoapods-fix-react-native/blob/89a78ad34950b5d6b3de657914c8ced8bf37ee8e/lib/cocoapods-fix-react-native/versions/0_55_3-post.rb#L140-L164

This should be the correct fix for facebook#17799.

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

Integrating React Native into an existing iOS project using CocoaPods without `DevSupport` subspec and seeing if the project successfully compiles.

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[IOS] [BUGFIX] [DevSupport] - Fix CocoaPods integration without DevSupport subspec
Closes facebook#19265

Differential Revision: D8149786

Pulled By: hramos

fbshipit-source-id: c665e463b76aacdfb2022e82e36eb381d2d9ff2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@shergin shergin Awaiting requested review from shergin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ikesyo @hramos @orta @facebook-github-bot @react-native-bot