Update Xcode projects #19574
Closed
Update Xcode projects #19574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
I'd accept this PR if it was limited to upgrading the project to recommended settings. Can you split out the method removals / replacements to a separate PR? |
5 tasks
|
alright. i will separate it. thanks. |
|
We recently merged a PR that fixed a bunch of these warnings, by the way. |
|
i saw, ill make sure to go from master, to see if i have some more stuff here. |
pvinis
force-pushed
the
feature/update-xcode-project
branch
from
ccce82f to
5ecedd5
Compare
|
@hramos done. only xcode recommendations here. ill make the rest into different prs. thanks again. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I'm reverting this as end to end tests are now broken. Let's work on a fix so we can land these changes successfully again. |
|
the erros are because of some method implementations that are broken on master. i had this fixed on the original pr. i think the best way forward it if i make a new pr with the method fixes for this. then after merging that one, we can merge this too. sounds good? |
|
pushed #19790, which has the fixes i had for e2e. the tests passed so i guess we could merge that one first. then this one, along with the 2-3 more i made, should be fine on merge. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
ill rebase right after #19574 lands on master. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 19, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for #19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes #19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
pvinis
force-pushed
the
feature/update-xcode-project
branch
from
5ecedd5 to
c6a52b6
Compare
|
rebased this to master. lets see if tests are happy now. |
|
Thanks @pvinis! |
facebook-github-bot
added
the
Import Started
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jun 21, 2018
This reverts commit 12410f3.
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jun 21, 2018
This reverts commit 13c60e2.
hramos
added a commit
to hramos/react-native
that referenced
this pull request
Jun 22, 2018
This reverts commit 12410f3.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. I made two react native projects, one with the regular react native and the other one using this branch. Left is before, right is after:  [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook#19574 Differential Revision: D8489006 Pulled By: hramos fbshipit-source-id: 2922b2e76aca6883c4f5d04e9c511b9fc1029583
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for facebook#19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes facebook#19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: @public A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook#19574 Reviewed By: shergin Differential Revision: D8530135 Pulled By: hramos fbshipit-source-id: b9c9ede0e07760cb2207caa6b468bd5c241848dc
sidnair
pushed a commit
to taptapsend/react-native
that referenced
this pull request
Aug 2, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for facebook#19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes facebook#19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. I made two react native projects, one with the regular react native and the other one using this branch. Left is before, right is after:  [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Differential Revision: D8489006 Pulled By: hramos fbshipit-source-id: 2922b2e76aca6883c4f5d04e9c511b9fc1029583
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Aug 17, 2018
Summary: @public A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Reviewed By: shergin Differential Revision: D8530135 Pulled By: hramos fbshipit-source-id: b9c9ede0e07760cb2207caa6b468bd5c241848dc
sidnair
pushed a commit
to taptapsend/react-native
that referenced
this pull request
Aug 21, 2018
Summary: These lines were causing erros with the e2e tests on ios. There are some methods that are not going to be called, and some definitions that are not correct. needed for facebook#19574. we will run the e2e tests. [INTERNAL] [MINOR] [Tests] - Fix some definitions. Closes facebook#19790 Differential Revision: D8509228 Pulled By: hramos fbshipit-source-id: 78650e347db52305a587e3461ac56877e3c79062
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 23, 2019
Summary: A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. I made two react native projects, one with the regular react native and the other one using this branch. Left is before, right is after:  [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Differential Revision: D8489006 Pulled By: hramos fbshipit-source-id: 2922b2e76aca6883c4f5d04e9c511b9fc1029583
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 23, 2019
Summary: @public A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Reviewed By: shergin Differential Revision: D8530135 Pulled By: hramos fbshipit-source-id: b9c9ede0e07760cb2207caa6b468bd5c241848dc
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 24, 2019
Summary: A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. I made two react native projects, one with the regular react native and the other one using this branch. Left is before, right is after:  [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Differential Revision: D8489006 Pulled By: hramos fbshipit-source-id: 2922b2e76aca6883c4f5d04e9c511b9fc1029583
bartolkaruza
pushed a commit
to bartolkaruza/react-native-cameraroll
that referenced
this pull request
Feb 24, 2019
Summary: @public A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Reviewed By: shergin Differential Revision: D8530135 Pulled By: hramos fbshipit-source-id: b9c9ede0e07760cb2207caa6b468bd5c241848dc
hramos
added
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations.
I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones.
Test Plan
I made two react native projects, one with the regular react native and the other one using this branch.
Left is before, right is after:
Release Notes
[IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements.