Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/ci lint proguard #19724

Closed
wants to merge 3 commits into from
Closed

Bugfix/ci lint proguard #19724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446a6b4
avoid android lint interrupt build
gengjiawen Jun 15, 2018
6fe8969
add soloader proguard rules
gengjiawen Jun 15, 2018
655a820
lock soloader to 0.3.0
gengjiawen Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions RNTester/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,11 @@ android {
signingConfig signingConfigs.release
}
}

lintOptions {
abortOnError false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rather fix the lint errors? might be masking errors, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirag04 we just added RNTester to this job, so I think it's fine to ignore lint errors right now to keep tests green. We should, however, have someone send PR(s) to fix any lint warnings that currently exist in master so that we can re-enable lint errors.

I have a similar issue where ShellCheck has surfaced a lot of issues in our shell scripts, but enabling it would turn tests red right away. In that particular case I plan to chip away at the shell issues until ShellCheck can be enabled fully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a quick run: #19743 CI is passing

}

// applicationVariants are e.g. debug, release
applicationVariants.all { variant ->
variant.outputs.each { output ->
Expand Down
8 changes: 8 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,12 @@ allprojects {
url "$androidSdk/extras/m2repository/"
}
}

project.configurations.all {
resolutionStrategy.eachDependency { details ->
if (details.requested.group == 'com.facebook.soloader') {
details.useVersion "0.3.0"
}
}
}
}