[Bridge] Check self.isValid in RCTBatchedBridge after initial script evaluation #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot import |
ide
force-pushed
the
bridge-valid-check
branch
from
375da69 to
8675622
Compare
ide
force-pushed
the
bridge-valid-check
branch
from
8675622 to
e566f26
Compare
|
friendly ping |
|
Damn bot @facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1691615787734006/int_phab to review. |
…evaluation I noticed that sometimes the batched bridge would be valid before `[self enqueueApplicationScript:url:onComplete:]` but then become invalid in the completion callback. This diff checks `self.isValid` inside of the callback. Test Plan: Load app a couple of times and see that my `RCTJavaScriptDidLoadNotification` observer is never notified by an invalid batched bridge.
ide
force-pushed
the
bridge-valid-check
branch
from
e566f26 to
af03e05
Compare
MattFoley
pushed a commit
to skillz/react-native
that referenced
this pull request
Nov 9, 2015
Summary: I noticed that sometimes the batched bridge would be valid before `[self enqueueApplicationScript:url:onComplete:]` but then become invalid in the completion callback. This diff checks `self.isValid` inside of the callback. Closes facebook#2016 Reviewed By: @trunkagent, @jspahrsummers Differential Revision: D2443438 Pulled By: @tadeuzagallo
Saadnajmi
added a commit
to FalseLobster/react-native
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes the batched bridge would be valid before
[self enqueueApplicationScript:url:onComplete:]but then become invalid in the completion callback. This diff checksself.isValidinside of the callback.Test Plan: Load app a couple of times and see that my
RCTJavaScriptDidLoadNotificationobserver is never notified by an invalid batched bridge.