Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Android NDK to r17b #20357

Closed
wants to merge 6 commits into from
Closed

Bump Android NDK to r17b #20357

wants to merge 6 commits into from

Conversation

dulmandakh
Copy link
Contributor

This PR bumps Android NDK version to r17b (latest). Cleaned up redundant LOCAL_EXPORT_CPPFLAGS rules in .mk files

Test Plan:

Everything compiles and runs as usual

Release Notes:

[ANDROID] [ENHANCEMENT] [NDK] - Bump to r17b version

@dulmandakh dulmandakh changed the title Bump ndk r17b Bump Android NDK to r17b Jul 24, 2018
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2018
@dulmandakh dulmandakh mentioned this pull request Jul 24, 2018
Closed
@dulmandakh dulmandakh requested review from gengjiawen, hramos and janicduplessis and removed request for gengjiawen July 24, 2018 11:50
@gengjiawen
Copy link
Contributor

Thanks for the job, nicely done. Let's wait the ci fixed on master and then merge this.

gengjiawen
gengjiawen approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Jul 24, 2018 via email

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Jul 25, 2018 •
edited
Loading

Done and CI is green 😄 (https://circleci.com/gh/dulmandakh/react-native/954). Had to bump buck because it was trying to use removed ABI from NDK, and buck v2018.07.09.01 fixed it with facebook/buck@4ef8e96.

@dulmandakh
Copy link
Contributor Author

@hramos please review and merge

@dulmandakh
Copy link
Contributor Author

I would like to note that RNTester app works as usual. And I found that LOCAL_EXPORT_CPPFLAGS exports CFLAGS to including module, which resulted in polluted and mixed CFLAGS.

This was referenced Jul 28, 2018
Closed
Closed
@fungilation
Copy link

Awesome PR! 2 birds with 1 stone.

@dulmandakh
Copy link
Contributor Author

@fkgozali please review and merge. RNTester app works just fine.

@dulmandakh dulmandakh mentioned this pull request Jul 29, 2018
Closed
@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 30, 2018
facebook-github-bot
facebook-github-bot approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @dulmandakh in 6117a6c.

Once this commit is added to a release, you will see the corresponding version tag below the description at 6117a6c. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 30, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 30, 2018
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Aug 17, 2018
@dulmandakh @facebook-github-bot
Bump Android NDK to r17b (#20357)
7e7d88c 
Summary:
This PR bumps Android NDK version to r17b (latest). Cleaned up redundant **LOCAL_EXPORT_CPPFLAGS** rules in .mk files
Pull Request resolved: facebook/react-native#20357

Differential Revision: D9068424

Pulled By: hramos

fbshipit-source-id: 8578637e38e807288b819a36cb75ea9feefcc09f
@dulmandakh dulmandakh deleted the bump-ndk-r17b branch August 22, 2018 03:14
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@dulmandakh @facebook-github-bot
Bump Android NDK to r17b (#20357)
53eea1b 
Summary:
This PR bumps Android NDK version to r17b (latest). Cleaned up redundant **LOCAL_EXPORT_CPPFLAGS** rules in .mk files
Pull Request resolved: facebook/react-native#20357

Differential Revision: D9068424

Pulled By: hramos

fbshipit-source-id: 8578637e38e807288b819a36cb75ea9feefcc09f
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
@facebook-github-bot facebook-github-bot added the Contributor A React Native contributor. label Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@hramos hramos Awaiting requested review from hramos

@janicduplessis janicduplessis Awaiting requested review from janicduplessis

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dulmandakh @gengjiawen @fungilation @react-native-bot @facebook-github-bot @hramos