Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ip.txt before SKIP_BUNDLING check #20554

Closed
wants to merge 1 commit into from

Conversation

keatongreve
Copy link
Contributor

@keatongreve keatongreve commented Aug 7, 2018

Fixes #20553.

Re-applies the change as described in #16533, which was closed for being stale. Thanks to @emusgrave for the original PR/change.

Test Plan:

  1. Ensure build directory clean
  2. Run a debug build targeting a physical iOS device
  3. Verify application loads JS bundle via a packager URL, and does not attempt to load a local pre-packaged JS bundle

Release Notes:

Help reviewers and the release process by writing your own release notes. See below for an example.

[INTERNAL] [BUGFIX] [./scripts] - Enable physical devices to still load from packager when SKIP_BUNDLING is set for clean Debug builds

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 20, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @keatongreve in 9c1ea45.

Once this commit is added to a release, you will see the corresponding version tag below the description at 9c1ea45. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 21, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 21, 2018
@keatongreve keatongreve deleted the keatongreve-20553 branch August 24, 2018 15:54
kelset pushed a commit that referenced this pull request Nov 26, 2018
Summary:
Fixes #20553.

Re-applies the change as described in #16533, which was closed for being stale. Thanks to emusgrave for the original PR/change.
Pull Request resolved: #20554

Differential Revision: D9414933

Pulled By: hramos

fbshipit-source-id: 8ebca57e32b905c4ecfd661524ca415f51162545
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
Fixes facebook#20553.

Re-applies the change as described in facebook#16533, which was closed for being stale. Thanks to emusgrave for the original PR/change.
Pull Request resolved: facebook#20554

Differential Revision: D9414933

Pulled By: hramos

fbshipit-source-id: 8ebca57e32b905c4ecfd661524ca415f51162545
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SKIP_BUNDLING prevents generating packager host IP for debugging on iOS devices
4 participants