-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate ip.txt before SKIP_BUNDLING check #20554
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
bd71205
to
057a1d5
Compare
057a1d5
to
631174b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was closed by @keatongreve in 9c1ea45. Once this commit is added to a release, you will see the corresponding version tag below the description at 9c1ea45. If the commit has a single |
Summary: Fixes facebook#20553. Re-applies the change as described in facebook#16533, which was closed for being stale. Thanks to emusgrave for the original PR/change. Pull Request resolved: facebook#20554 Differential Revision: D9414933 Pulled By: hramos fbshipit-source-id: 8ebca57e32b905c4ecfd661524ca415f51162545
Fixes #20553.
Re-applies the change as described in #16533, which was closed for being stale. Thanks to @emusgrave for the original PR/change.
Test Plan:
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[INTERNAL] [BUGFIX] [./scripts] - Enable physical devices to still load from packager when SKIP_BUNDLING is set for clean Debug builds