Android. OkHttp crash fixed on upload re-try. #20802
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
🌐Networking
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Aug 23, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @dryganets in 79fe925. Once this commit is added to a release, you will see the corresponding version tag below the description at 79fe925. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Aug 23, 2018
aleclarson
pushed a commit
to aleclarson/react-native
that referenced
this pull request
Sep 16, 2018
Summary: This change fixes this issue: facebook#10423 Pull Request resolved: facebook#20802 Differential Revision: D9478422 Pulled By: hramos fbshipit-source-id: ce3a098a71c8f50a62b011a2a277004ab7a7b655
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This change fixes this issue: facebook#10423 Pull Request resolved: facebook#20802 Differential Revision: D9478422 Pulled By: hramos fbshipit-source-id: ce3a098a71c8f50a62b011a2a277004ab7a7b655
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This change fixes this issue: facebook#10423 Pull Request resolved: facebook#20802 Differential Revision: D9478422 Pulled By: hramos fbshipit-source-id: ce3a098a71c8f50a62b011a2a277004ab7a7b655
elicwhite
added
p: Microsoft
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes this issue:
#10423
Test Plan:
In order to reproduce the problem I'm fixing here you need to simulate short network outage during upload of the big file.
For example, you could plug out an ethernet cable from the wifi hotspot your Android phone is connected to.
Release Notes:
[Android] [Bugfix] [Networking] - Okhttp crash fix on upload retry.