Fix all build/test issues on master for android, detox & objc CI stages + update to Babel 7 #20854

Salakar · 2018-08-25T21:29:47Z

This 'fixes' the following failing CI stages:

test_android
test_objc
test_detox_end_to_end

Fixes

Missing Buck Dependency

This fixes Android tests failing to build on master when running:

./scripts/run-android-local-unit-tests.sh

Without this master fails to build with the following error:

This commit appears to be the culprit: bce77c8 - Android support annotations imported but buck file was not updated.

JS Bundles not being transformed with the React Native Babel preset

There's an issue with building JS bundles - no Babel preset is being applied to RNTester when using local-cli which causes a syntax error on Flow types and on JSX syntax:

KEEP: To fix this I've added a new format babel.config.js file at the root which works for both jest (babelrc: false is set on options so does not interfere) and RNTester/local-cli bundled output (babel-preset-react-native). Additionally react-native-xcode.sh was updated to run Node from the project root - otherwise it never picks up the babel config and will fail to run with the same issues as before.

EDIT: Below is no longer relevant - all updated to now use the release version of Babel v7.0.0
REMOVE: Once babel-preset-react-native has been updated to use beta.56 the babel.config.js can be updated to just be the following and all the deps taken out the package.json again (except for RN preset):

This one is for reference and not merging as babel-preset-react-native needs it's Babel deps updating to v7.0.0-beta.56 to match metro's Babel dep version to fix this. To confirm it's building on these versions i've added them to the package.json for now.

// KEEP
module.exports = {
  presets: ['metro-react-native-babel-preset'],
  plugins: [
    '@babel/plugin-transform-runtime',
  ],
};

I would PR to babel-preset-react-native but I can no longer find it, doesn't seem to exist on GitHub anymore - it was in the root of the project before?
EDIT: this is now metro-react-native-babel-preset - and latest version is now added.

Test Plan:

Ran the Android local unit test shell script (as above), tests have all passed, output:
Ran the jest tests (npm run test), tests have all passed, output:
Full CI passing 👀

Release Notes:

N/A - Internals

…to be passed to reject

…ap instance to be passed to reject

…ary and not done anywhere else - prevents a 'ambiguous method' error as rejects 3rd arg can be Throwable or Writable map.

…ot babel.config.js file

pull-bot · 2018-08-25T23:00:16Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️	❗ Big PR - This PR is extremely unlikely to get reviewed because it touches 2352 lines.

Generated by 🚫 dangerJS

…ACT_NATIVE_DIR directory - otherwise the Babel config file is ignored

…n - otherwise: babel/babel#8508

package.json

jest/preprocessor.js

kelset · 2018-08-28T09:29:47Z

Hey @Salakar thanks for the PR! I have left some comments because I fear I may be missing some things here and there.

cc @hramos who may also want to check this before we merge

Salakar · 2018-08-28T15:11:06Z

@kelset no worries!

I'd personally avoid merging this yet as is, sorry - as we don't really want all these extra Babel dev deps being added to the project - these will be gone shortly; once I add in "metro-react-native-babel-preset": "0.44.x" all the others can be removed - I will sort and add commits here to cleanup, give me a couple hours 👍

(I was unaware that the preset had moved to metro-react-native-babel-preset - which is why I added these extra dev deps in as a interim solution to waiting for babel-preset-react-native to be updated - which as you've pointed out is now part of metro packages - so I will sort)

…Babel 7 devDeps. Additionally update metro dependencies to ^0.44.0 to keep Babel 7 versions consistent.

Salakar · 2018-08-28T18:08:34Z

@kelset changes done and passing again.

I've switched it over to the metro-react-native-babel-preset preset at version ^0.44.0 and also updated the other metro* dependencies to match this version (internally these all use beta.56 of Babel 7).

All the other Babel dependencies have been removed as no longer required.

Notes

@babel/plugin-transform-runtime (and in the babel.config) is required otherwise the following error occurs on bundling:

Potentially related PR: https://github.com/facebook/metro/pull/198/files

@babel/runtime is required to pair with @babel/plugin-transform-runtime otherwise the following error occurs:

Once metro has been updated to use Babel 7 the following diff can be applied:

--- a/package.json
+++ b/package.json
@@ -170,10 +170,10 @@
     "graceful-fs": "^4.1.3",
     "inquirer": "^3.0.6",
     "lodash": "^4.17.5",
-    "metro": "^0.44.0",
-    "metro-babel-register": "^0.44.0",
-    "metro-core": "^0.44.0",
-    "metro-memory-fs": "^0.44.0",
+    "metro": "^0.45.0",
+    "metro-babel-register": "^0.45.0",
+    "metro-core": "^0.45.0",
+    "metro-memory-fs": "^0.45.0",
     "mime": "^1.3.4",
     "minimist": "^1.2.0",
     "mkdirp": "^0.5.1",
@@ -202,12 +202,12 @@
     "yargs": "^9.0.0"
   },
   "devDependencies": {
-    "@babel/core": "7.0.0-beta.56",
-    "@babel/runtime": "7.0.0-beta.56",
-    "@babel/plugin-transform-runtime": "7.0.0-beta.56",
-    "metro-react-native-babel-preset": "^0.44.0",
+    "@babel/core": "^7.0.0",
+    "@babel/runtime": "^7.0.0",
+    "@babel/plugin-transform-runtime": "^7.0.0",
+    "metro-react-native-babel-preset": "^0.45.0",
     "async": "^2.4.0",
-    "babel-eslint": "9.0.0-beta.2",
+    "babel-eslint": "^9.0.0",
     "detox": "^8.0.0",
     "eslint": "5.1.0",
     "eslint-config-fb-strict": "22.1.0",

(babel-eslint included as this runs on a beta Babel 7 currently - updating to v9.0.0 will on ^7.0.0)

… no longer in-use react_native_dep's

Salakar · 2018-08-31T14:43:09Z

@kelset should be good to go now 🤞 EDIT - yep all good 🎉

I had to fix a few more things after updating from master; specifically, buck issues - there were redundant & duplicate dependencies defined on master that was breaking build/buck fetch.

Sorry for the delay - on a different Mac today so had to re-setup my environment 😫

kelset · 2018-08-31T14:47:12Z

No problem! Thanks for doing this 💪 I'll check with Mike, maybe we can even get this in for rc4 :)

Salakar · 2018-08-31T14:54:16Z

@kelset no problem :) will also give RC4 a whirl this weekend and upgrade our tests suite/app for invertase/react-native-firebase to use it and see what happens 🔥

hramos · 2018-08-31T15:37:35Z

I just saw this PR - @Salakar thanks so much for working on this!

facebook-github-bot

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

.flowconfig

jest/preprocessor.js

… of these types via `metro-config` types, see circleci.com/gh/facebook/react-native/50738

-

Revert "-"

Salakar · 2018-08-31T17:03:15Z

Ignore last 2 commits sorry - I derped and merged my local master into my PR branch - I reverted immediately though so it's back to normal. 🙈

facebook-github-bot · 2018-09-01T05:48:32Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

Salakar · 2018-09-01T10:22:36Z

My guess is it's this commit 10 hours ago: a8a63b1 😫 will sync up again shortly

EDIT: most likely was the NPM DNS/SSL issue that caused this to fail. Had no issues locally with this commit and all the other CI stages are running fine 👍

…o cherry-pick

Salakar · 2018-09-01T11:25:32Z

Right so I synced up to master and everything runs fine locally - I think the failure may be due to an ongoing NPM service outage at the moment:

Yarn installs are failing because of this - network connectivity issue on the build log: https://circleci.com/gh/facebook/react-native/51201?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

EDIT: yep just the NPM outage issue - can re-run test_node10 once connectivity issue is resolved

gengjiawen · 2018-09-01T14:30:41Z

@hramos The import failed, need to import again.

facebook-github-bot

hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Salakar · 2018-09-13T12:00:03Z

Will close this PR now as several commits have now been merged that are a subset of this PR.

Thanks all.

Salakar added 5 commits August 25, 2018 18:35

[android] update Promise interface & to allow a userInfo WritableMap …

d6a4838

…to be passed to reject

[android] update Promise implementation to allow a userInfo WritableM…

346b733

…ap instance to be passed to reject

[android] remove inconsistent promise.reject with null arg - unnecess…

41e34bf

…ary and not done anywhere else - prevents a 'ambiguous method' error as rejects 3rd arg can be Throwable or Writable map.

[android] fix failing unit tests build - missing buck dependency

6d0aa8e

[android] fix failing unit tests build - missing buck dependency

9045294

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2018

react-native-bot added Platform: Android Android applications. ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Aug 25, 2018

[bundler] fix bundle failing to compile - babel7 changes + missing ro…

3919d36

…ot babel.config.js file

Salakar requested a review from hramos as a code owner August 25, 2018 22:57

Salakar changed the title ~~[android] Fix build on master for unit tests - missing buck config~~ [android][bundler] Fix build issues on master for unit & integration tests Aug 25, 2018

Salakar changed the title ~~[android][bundler] Fix build issues on master for unit & integration tests~~ [android][bundler][wip] Fix build issues on master for unit & integration tests Aug 25, 2018

[build] update to babel7 rc3 & exclude jest from babelrc

a993a77

Salakar changed the title ~~[android][bundler][wip] Fix build issues on master for unit & integration tests~~ [wip] Fix all build/test issues on master for android, detox & objc stages Aug 25, 2018

Salakar added 2 commits August 26, 2018 01:40

[build] update react-native-xcode script to start Node from the $RE…

c9b2d2e

…ACT_NATIVE_DIR directory - otherwise the Babel config file is ignored

[build] Babel 7 - needs to be 7.0.0-beta.56 to match metro's versio…

3af30df

…n - otherwise: babel/babel#8508

Salakar changed the title ~~[wip] Fix all build/test issues on master for android, detox & objc stages~~ Fix all build/test issues on master for android, detox & objc CI stages Aug 26, 2018

matei-radu mentioned this pull request Aug 27, 2018

Update link command for Android project #20853

Closed

matthargett approved these changes Aug 27, 2018

View reviewed changes

empyrical mentioned this pull request Aug 28, 2018

Add support for out-of-tree platform plugins #20825

Closed

kelset reviewed Aug 28, 2018

View reviewed changes

package.json Outdated Show resolved Hide resolved

kelset reviewed Aug 28, 2018

View reviewed changes

package.json Outdated Show resolved Hide resolved

kelset reviewed Aug 28, 2018

View reviewed changes

jest/preprocessor.js Show resolved Hide resolved

kelset mentioned this pull request Aug 28, 2018

[v0.57.0-rc.3] New project unit testing doesn't work #20876

Closed

3 tasks

Switch to metro-react-native-babel-preset and remove now redundant …

5a440ca

…Babel 7 devDeps. Additionally update metro dependencies to ^0.44.0 to keep Babel 7 versions consistent.

Salakar added 2 commits August 31, 2018 15:00

[buck] remove unused react_native_dep

c2439e4

[buck][tests] remove duplicate react_native_dep (jsr-305:jsr-305) and…

39d054d

… no longer in-use react_native_dep's

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Aug 31, 2018

facebook-github-bot approved these changes Aug 31, 2018

View reviewed changes

elicwhite reviewed Aug 31, 2018

View reviewed changes

.flowconfig Show resolved Hide resolved

jest/preprocessor.js Show resolved Hide resolved

Salakar added 5 commits August 31, 2018 17:04

[flow][android] remove metro ignore from config - local-cli makes use…

fe5f3b4

… of these types via `metro-config` types, see circleci.com/gh/facebook/react-native/50738

Add comment indicating the babel.config.js files purpose

6ad1be5

Merge pull request #1 from invertase/master

488e233

-

Revert "-"

305bd44

Merge pull request #2 from invertase/revert-1-master

b47f7a5

Revert "-"

facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Sep 1, 2018

Merge branch 'master' of https://github.com/facebook/react-native int…

42b55b0

…o cherry-pick

gengjiawen approved these changes Sep 1, 2018

View reviewed changes

Salakar mentioned this pull request Sep 1, 2018

[android] Allow 'userInfo' for native promise.reject + add native error stack support #20940

Closed

Salakar changed the title ~~Fix all build/test issues on master for android, detox & objc CI stages~~ Fix all build/test issues on master for android, detox & objc CI stages + update to Babel 7 Sep 3, 2018

facebook-github-bot reviewed Sep 4, 2018

View reviewed changes

hramos added a commit to hramos/react-native that referenced this pull request Sep 5, 2018

Subset of facebook#20854

f6d9919

Salakar closed this Sep 13, 2018

hramos removed the Import Failed label Mar 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all build/test issues on master for android, detox & objc CI stages + update to Babel 7 #20854

Fix all build/test issues on master for android, detox & objc CI stages + update to Babel 7 #20854

Salakar commented Aug 25, 2018 •

edited

Loading

pull-bot commented Aug 25, 2018 •

edited

Loading

kelset commented Aug 28, 2018

Salakar commented Aug 28, 2018 •

edited

Loading

Salakar commented Aug 28, 2018 •

edited

Loading

Salakar commented Aug 31, 2018 •

edited

Loading

kelset commented Aug 31, 2018

Salakar commented Aug 31, 2018

hramos commented Aug 31, 2018

facebook-github-bot left a comment

Salakar commented Aug 31, 2018 •

edited

Loading

facebook-github-bot commented Sep 1, 2018

Salakar commented Sep 1, 2018 •

edited

Loading

Salakar commented Sep 1, 2018 •

edited

Loading

gengjiawen commented Sep 1, 2018

facebook-github-bot left a comment

Salakar commented Sep 13, 2018

Fix all build/test issues on master for android, detox & objc CI stages + update to Babel 7 #20854

Fix all build/test issues on master for android, detox & objc CI stages + update to Babel 7 #20854

Conversation

Salakar commented Aug 25, 2018 • edited Loading

Fixes

Missing Buck Dependency

JS Bundles not being transformed with the React Native Babel preset

Test Plan:

Release Notes:

pull-bot commented Aug 25, 2018 • edited Loading

kelset commented Aug 28, 2018

Salakar commented Aug 28, 2018 • edited Loading

Salakar commented Aug 28, 2018 • edited Loading

Notes

Salakar commented Aug 31, 2018 • edited Loading

kelset commented Aug 31, 2018

Salakar commented Aug 31, 2018

hramos commented Aug 31, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

Salakar commented Aug 31, 2018 • edited Loading

facebook-github-bot commented Sep 1, 2018

Salakar commented Sep 1, 2018 • edited Loading

Salakar commented Sep 1, 2018 • edited Loading

gengjiawen commented Sep 1, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

Salakar commented Sep 13, 2018

Salakar commented Aug 25, 2018 •

edited

Loading

pull-bot commented Aug 25, 2018 •

edited

Loading

Salakar commented Aug 28, 2018 •

edited

Loading

Salakar commented Aug 28, 2018 •

edited

Loading

Salakar commented Aug 31, 2018 •

edited

Loading

Salakar commented Aug 31, 2018 •

edited

Loading

Salakar commented Sep 1, 2018 •

edited

Loading

Salakar commented Sep 1, 2018 •

edited

Loading