Use the round launcher icon available since 7.1 #20968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default react-native template has ic_launcher_round icons on the resources but has not been used.
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 5, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@syaau merged commit 27a07cf into Once this commit is added to a release, you will see the corresponding version tag below the description at 27a07cf. If the commit has a single |
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary: The default react-native template has ic_launcher_round icons on the resources but has not been used. Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook#20968 Differential Revision: D9661731 Pulled By: hramos fbshipit-source-id: ad8f2f952df2c32aea2a8d3e69c445ed27387aa6
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: The default react-native template has ic_launcher_round icons on the resources but has not been used. Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook/react-native#20968 Differential Revision: D9661731 Pulled By: hramos fbshipit-source-id: ad8f2f952df2c32aea2a8d3e69c445ed27387aa6
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: The default react-native template has ic_launcher_round icons on the resources but has not been used. Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged. Pull Request resolved: facebook#20968 Differential Revision: D9661731 Pulled By: hramos fbshipit-source-id: ad8f2f952df2c32aea2a8d3e69c445ed27387aa6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default react-native template has ic_launcher_round icons on the resources but has not been used.
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
Test Plan:
This is just a minor attribute addition for android application. Tested with existing applications
Release Notes:
[ANDROID][MINOR][Template] - Use round launcher icon