Change the number of days to kill stales from 3 to 7 #21015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Core Team
Missing Test Plan
|
Thanks for the PR! 30 days was too long of a time period, and I agree that 3 days turned out to be too aggressive. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 7, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@kelset merged commit 095eacd into Once this commit is added to a release, you will see the corresponding version tag below the description at 095eacd. If the commit has a single |
gengjiawen
pushed a commit
to gengjiawen/react-native
that referenced
this pull request
Sep 14, 2018
Summary: Basically, saw this commit this morning and had a chance to discuss it with matthargett and AndrewJack and overall I agree with their criticism about 3 days being too little time for people to react to it. Pull Request resolved: facebook#21015 Differential Revision: D9721393 Pulled By: hramos fbshipit-source-id: 524c0b87987a8b76fa8d5e223fb5ed5a56a8c648
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Basically, saw this commit this morning and had a chance to discuss it with matthargett and AndrewJack and overall I agree with their criticism about 3 days being too little time for people to react to it. Pull Request resolved: facebook#21015 Differential Revision: D9721393 Pulled By: hramos fbshipit-source-id: 524c0b87987a8b76fa8d5e223fb5ed5a56a8c648
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, saw this commit this morning and had a chance to discuss it with @matthargett and @AndrewJack and overall I agree with their criticism about 3 days being too little time for people to react to it.