Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oneTimeCode to textContentType typings #21069

Conversation

blake-simpson
Copy link

iOS 12 supports a new textContentType attribute with the value oneTimeCode for extracting security codes from single-factor SMS login flows.

https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_a_text_input_view

This commit adds the Flow typings and Prop Types.

As far as I can see no changes need to be made to the iOS code for this change.

If this change is accepted I would also make a follow-up PR for the documentation.

Release Notes:

[IOS] [ENHANCEMENT] [TextInput] - Added oneTimeCode typings and prop types to the textContentType prop of TextInput.

iOS 12 supports a new `textContentType` attribute with the value `oneTimeCode` for extracting security codes from single-factor SMS login flows.

https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_a_text_input_view

This commit adds the Flow typings and Prop Types.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@react-native-bot react-native-bot added Missing Test Plan This PR appears to be missing a test plan. ✅Release Notes labels Sep 12, 2018
@elicwhite
Copy link
Member

Thanks for contributing this PR but I'm landing #21079 in favor of this since it adds another one as well.

@elicwhite elicwhite closed this Sep 13, 2018
@blake-simpson
Copy link
Author

That makes sense, thanks for the response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Missing Test Plan This PR appears to be missing a test plan.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants