Remove PropTypes from Modal.js #21279
Conversation
facebook-github-bot
added
the
CLA Signed
Libraries/Modal/Modal.js
Outdated
| |}>, | ||
| >; | ||
|
|
||
| export type ModalProps = $ReadOnly<{| |
Libraries/Modal/Modal.js
Outdated
| * | ||
| * See https://facebook.github.io/react-native/docs/modal.html#supportedorientations | ||
| */ | ||
| supportedOrientations?: ?Array< |
Libraries/Modal/Modal.js
Outdated
| * | ||
| * See https://facebook.github.io/react-native/docs/modal.html#supportedorientations | ||
| */ | ||
| supportedOrientations?: ?ReadOnlyArray< |
There was a problem hiding this comment.
$ReadOnlyArray, missing the $
There was a problem hiding this comment.
TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Libraries/Modal/Modal.js
Outdated
| * | ||
| * See https://facebook.github.io/react-native/docs/modal.html#onrequestclose | ||
| */ | ||
| onRequestClose?: (event?: SyntheticEvent<null>) => mixed, |
There was a problem hiding this comment.
This diff fails to land internally because of callsites that pass null to onRequestClose. We typically like to make optional arguments nullable to enable spreading props and other things to work. Can you update this type and the others in this diff that are optional to also be nullable?
onRequestClose?: ?(event?: SyntheticEvent<null>) => mixed,
There was a problem hiding this comment.
TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This caught a few invalid callsites internally that will have to get fixed for this to land. |
|
@empyrical merged commit 6b89214 into Once this commit is added to a release, you will see the corresponding version tag below the description at 6b89214. If the commit has a single |
Summary: This PR converts the Prop Types in `Modal` to Flow Types, and fills out the callback types a bit more. Context Types are left in for now. Pull Request resolved: facebook#21279 Reviewed By: yungsters Differential Revision: D10006795 Pulled By: TheSavior fbshipit-source-id: ac885f2e5f068b0991009a9b1cbb3886e34941af
This PR converts the Prop Types in
Modalto Flow Types, and fills out the callback types a bit more.Context Types are left in for now.
Test Plan:
flow checkpasses.Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Modal/Modal.js] - Converted Prop Types to Flow Types