Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make google repo priority higher than jcenter #21910

Closed
wants to merge 2 commits into from
Closed

Make google repo priority higher than jcenter #21910

wants to merge 2 commits into from

Conversation

sunnylqm
Copy link
Contributor

Fixes #21907 (comment) and prevent similar issues happening again

@sunnylqm
Make google repo priority higher than jcenter
f3306ba 
Fixes facebook#21907 (comment) and prevent similar issues happening again
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 23, 2018
@sunnylqm
Copy link
Contributor Author

ping @kelset @grabbou
This is a hotfix. Now all new 0.57.x project can not build on android.

@fathyb fathyb mentioned this pull request Oct 23, 2018
Merged
fathyb added a commit to segmentio/analytics-react-native that referenced this pull request Oct 23, 2018
@fathyb
chore(test-app): fix Android build (#10)
365827f 
CI is broken on Android since today, applying a quick workaround to keep CI green while the react-native team figures it out.

See:
- facebook/react-native#21910
- facebook/react-native#21907
@dulmandakh
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Oct 24, 2018
@facebook-github-bot
Copy link
Contributor

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

@kelset
Copy link
Contributor

kelset commented Oct 24, 2018 •
edited
Loading

Thanks for the PR, we'll try to have this merged ASAP as it should fix the issue we are having on the CI for android test ✅ (in the 0.57 stable branch)

@kelset kelset mentioned this pull request Oct 24, 2018
Closed
@kelset
Copy link
Contributor

kelset commented Oct 24, 2018 •
edited
Loading

btw @sunnylqm shouldn't this change be done in the root level build.gradle too? 🤔

@sunnylqm
Copy link
Contributor Author

@kelset For end user only build.gradle in template works right? I dont know what is the root build.gradle for? If that is for CI, I can add that change too

@pull-bot
Copy link

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@kelset
Copy link
Contributor

kelset commented Oct 24, 2018

I think that yeah, the root one defines the "overall" react native android config. Anyway, in the meantime, I've tried to replicate your change on the 0.57-stable branch to see if it fixes the CI there (and now the test_android is green) -> 7a766bf

@mmccartney
Copy link
Contributor

I think it is safer to move jcenter() below google() rather than moving google() to the top (above mavenLocal()). I agree we desperately need the templates fixed because the following doesn't work:

react-native init AwesomeProject
cd AwesomeProject
react-native run-android # <-- build fails because jcenter is borken

@pestrada pestrada mentioned this pull request Oct 24, 2018
Closed
@hramos
Copy link
Contributor

hramos commented Oct 24, 2018

Will land this one as is, but @mmccartney feel free to send another PR with your suggested changes.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Oct 24, 2018
facebook-github-bot
facebook-github-bot approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@sunnylqm merged commit 88981a8 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 24, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 24, 2018
grabbou pushed a commit to react-native-community/cli that referenced this pull request Nov 6, 2018
@sunnylqm @facebook-github-bot
Make google repo priority higher than jcenter (#21910)
6b181d6 
Summary:
Fixes facebook/react-native#21907 (comment) and prevent similar issues happening again
Pull Request resolved: facebook/react-native#21910

Differential Revision: D10842256

Pulled By: hramos

fbshipit-source-id: f4abaa1c8ff8df6f0fb57b1bad745f4df9da7143
@hramos hramos removed the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 6, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed labels Feb 6, 2019
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@sunnylqm @facebook-github-bot
Make google repo priority higher than jcenter (facebook#21910)
7118e34 
Summary:
Fixes facebook#21907 (comment) and prevent similar issues happening again
Pull Request resolved: facebook#21910

Differential Revision: D10842256

Pulled By: hramos

fbshipit-source-id: f4abaa1c8ff8df6f0fb57b1bad745f4df9da7143
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@dulmandakh dulmandakh dulmandakh approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sunnylqm @dulmandakh @facebook-github-bot @kelset @pull-bot @mmccartney @hramos @react-native-bot