Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Close websocket properly when remote server initiates close #22248

Closed
wants to merge 3 commits into from
Closed

Android: Close websocket properly when remote server initiates close #22248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98b86ea
Use the round launcher icon available since 7.1
syaau Sep 4, 2018
fc50703
Merge branch 'master' of github.com:facebook/react-native
syaau Oct 7, 2018
bcd52f7
Close websocket properly when the remote initiates the close
syaau Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,11 @@ public void onOpen(WebSocket webSocket, Response response) {
sendEvent("websocketOpen", params);
}

@Override
public void onClosing(WebSocket websocket, int code, String reason) {
websocket.close(code, reason);
}

@Override
public void onClosed(WebSocket webSocket, int code, String reason) {
WritableMap params = Arguments.createMap();
Expand Down