Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not land] test new jsc #22334

Closed
wants to merge 3 commits into from
Closed

[Do not land] test new jsc #22334

wants to merge 3 commits into from

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Nov 18, 2018 •
edited
Loading

don't land it now, it contains binary for test.

Showcase: https://github.com/gengjiawen/ReactNativeNewJsc.

Details not handled:

@gengjiawen gengjiawen requested a review from hramos as a code owner November 18, 2018 09:59
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2018
@hramos
Copy link
Contributor

hramos commented Jan 15, 2019

Should we keep this open? The new JSC is in master now.

@gengjiawen gengjiawen closed this Jan 15, 2019
@gengjiawen
Copy link
Contributor Author

nope, it can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @hramos @facebook-github-bot @react-native-bot