Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Standalone for NativeComponents] RCTPicker #22996

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions Libraries/Components/Picker/PickerIOS.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const ReactNative = require('ReactNative');
const StyleSheet = require('StyleSheet');
const View = require('View');
const processColor = require('processColor');
const requireNativeComponent = require('requireNativeComponent');
const RCTPickerNativeComponent = require('RCTPickerNativeComponent');

import type {SyntheticEvent} from 'CoreEventTypes';
import type {ColorValue} from 'StyleSheetTypes';
Expand All @@ -38,24 +38,6 @@ type RCTPickerIOSItemType = $ReadOnly<{|
textColor: ?number,
|}>;

type RCTPickerIOSType = Class<
ReactNative.NativeComponent<
Chi-AnTai marked this conversation as resolved.
Show resolved Hide resolved
$ReadOnly<{|
items: $ReadOnlyArray<RCTPickerIOSItemType>,
onChange: (event: PickerIOSChangeEvent) => void,
onResponderTerminationRequest: () => boolean,
onStartShouldSetResponder: () => boolean,
selectedIndex: number,
style?: ?TextStyleProp,
testID?: ?string,
|}>,
>,
>;

const RCTPickerIOS: RCTPickerIOSType = (requireNativeComponent(
'RCTPicker',
): any);

type Label = Stringish | number;

type Props = $ReadOnly<{|
Expand Down Expand Up @@ -111,7 +93,7 @@ class PickerIOS extends React.Component<Props, State> {
render() {
return (
<View style={this.props.style}>
<RCTPickerIOS
<RCTPickerNativeComponent
ref={picker => {
this._picker = picker;
}}
Expand Down
48 changes: 48 additions & 0 deletions Libraries/Components/Picker/RCTPickerNativeComponent.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
* @format
*/
'use strict';

const requireNativeComponent = require('requireNativeComponent');

import type {SyntheticEvent} from 'CoreEventTypes';
import type {TextStyleProp} from 'StyleSheet';

type PickerIOSChangeEvent = SyntheticEvent<
$ReadOnly<{|
newValue: number | string,
newIndex: number,
|}>,
>;

type RCTPickerIOSItemType = $ReadOnly<{|
label: ?Label,
value: ?(number | string),
textColor: ?number,
|}>;

type Label = Stringish | number;

type RCTPickerIOSType = Class<
ReactNative.NativeComponent<
Chi-AnTai marked this conversation as resolved.
Show resolved Hide resolved
$ReadOnly<{|
items: $ReadOnlyArray<RCTPickerIOSItemType>,
onChange: (event: PickerIOSChangeEvent) => void,
onResponderTerminationRequest: () => boolean,
onStartShouldSetResponder: () => boolean,
selectedIndex: number,
style?: ?TextStyleProp,
testID?: ?string,
|}>,
>,
>;

module.exports = ((requireNativeComponent(
Chi-AnTai marked this conversation as resolved.
Show resolved Hide resolved
'RCTPicker',
): any): RCTPickerIOSType);
Chi-AnTai marked this conversation as resolved.
Show resolved Hide resolved