-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Standalone for NativeComponents] AndroidDropdownPicker and AndroidDialogPicker #22999
[Standalone for NativeComponents] AndroidDropdownPicker and AndroidDialogPicker #22999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
eslint
found some issues.flow
found some issues.
accessibilityLabel?: ?string, | ||
|}>; | ||
|
||
type DialogPickerNativeType = Class<NativeComponent<NativeProps>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier/prettier: Insert ;
|
||
module.exports = ((requireNativeComponent( | ||
'AndroidDialogPicker', | ||
): any): DialogPickerNativeType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear type. Using any
, Object
, or Function
types is not safe! (unclear-type
)
|
||
module.exports = ((requireNativeComponent( | ||
'AndroidDropdownPicker', | ||
): any): DropdownPickerNativeType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear type. Using any
, Object
, or Function
types is not safe! (unclear-type
)
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code analysis results:
flow
found some issues.
|
||
module.exports = ((requireNativeComponent( | ||
'AndroidDialogPicker', | ||
): any): DialogPickerNativeType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear type. Using any
, Object
, or Function
types is not safe! (unclear-type
)
|
||
module.exports = ((requireNativeComponent( | ||
'AndroidDropdownPicker', | ||
): any): DropdownPickerNativeType); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclear type. Using any
, Object
, or Function
types is not safe! (unclear-type
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@Naturalclar merged commit 462cb10 into |
Thanks for contributing! |
Summary: Changelog: ---------- [Android] [Changed] - As mentioned in facebook#22990, I have moved native components required by PickerAndroid.android.js into separate files and added Flow Typing. Pull Request resolved: facebook#22999 Differential Revision: D13697130 Pulled By: TheSavior fbshipit-source-id: 42da73d82cca45fefa066871eed5a637811643c8
Changelog:
[Android] [Changed] - As mentioned in #22990, I have moved native components required by PickerAndroid.android.js into separate files and added Flow Typing.
Test Plan: