Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standalone for NativeComponents] AndroidCheckBox #23003

Closed
wants to merge 2 commits into from
Closed

[Standalone for NativeComponents] AndroidCheckBox #23003

wants to merge 2 commits into from

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Jan 15, 2019 •
edited
Loading

This PR is related to #22990

Changelog:

[Android][Changed] - move the call to requireNativeComponent from Checkbox.android.js to AndroidCheckBoxNativeComponent.js

Test Plan:

  • npm run lint
  • npm run flow-check-android
  • npm run flow-check-ios
  • npm run flow
  • npm run test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 15, 2019
@react-native-bot react-native-bot added the Platform: Android Android applications. label Jan 15, 2019
@rickhanlonii rickhanlonii self-assigned this Jan 16, 2019
rickhanlonii
rickhanlonii approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

facebook-github-bot
facebook-github-bot reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@nd-02110114 merged commit eb171d2 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 16, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 16, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@nissy-dev @facebook-github-bot
AndroidCheckBox (facebook#23003)
c669734 
Summary:
This PR is related to facebook#22990

Changelog:
----------
[Android][Changed]  - move the call to requireNativeComponent from `Checkbox.android.js` to `AndroidCheckBoxNativeComponent.js`
Pull Request resolved: facebook#23003

Reviewed By: TheSavior

Differential Revision: D13690827

Pulled By: rickhanlonii

fbshipit-source-id: 08bc83a7f097414b5c833a3b43715e5aec277d65
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees

@rickhanlonii rickhanlonii

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nissy-dev @react-native-bot @rickhanlonii @facebook-github-bot @hramos