[Standalone for NativeComponents] ToolbarAndroid #23009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
🔶Components
Component: ToolbarAndroid
Platform: Android
sasurau4
force-pushed
the
rn-22990-ToolbarAndroid
branch
from
d6130ef
to
c29ae6f
Compare
sasurau4
changed the title
sasurau4
changed the title
|
|
|
@TheSavior Thanks for response! |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for contributing! |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: [Android] [Changed] - create standalone JS file for ToolbarAndroid, as part of facebook#22990 I have a question. `ToolbarAndroid` component use 2 types from other files. They are not included files mentioned by facebook#22990 (comment). One type `ColorValue` is very simple and I'll copy it. But `ImageSource` type is a bit complicated I think it wolud be better to add to the codegen. How do you think about it? TheSavior Update: -> solved 👍 ---------- - [x] yarn lint - [x] yarn flow-check-android - [x] yarn flow - [x] yarn test Pull Request resolved: facebook#23009 Differential Revision: D13697524 Pulled By: TheSavior fbshipit-source-id: 72ce43e1510be0986a3798d795f07ab176bd2a92
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
[Android] [Changed] - create standalone JS file for ToolbarAndroid, as part of #22990
Question
I have a question.
ImageSourceis sufficiently complex not to be duplicate code?ToolbarAndroidcomponent use 2 types from other files.They are not included files mentioned by #22990 (comment).
One type
ColorValueis very simple and I'll copy it.But
ImageSourcetype is a bit complicated I think it wolud be better to add to the codegen.How do you think about it? @TheSavior
Update: -> solved 👍
Test Plan