[Standalone for NativeComponents] RCTSlider #23048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Jan 17, 2019
|
|
||
| const requireNativeComponent = require('requireNativeComponent'); | ||
|
|
||
| module.exports = requireNativeComponent('RCTSlider'); |
|
|
||
| const requireNativeComponent = require('requireNativeComponent'); | ||
|
|
||
| module.exports = requireNativeComponent('RCTSlider'); |
There was a problem hiding this comment.
eol-last: Newline required at end of file but not found.
elicwhite
reviewed
Jan 18, 2019
|
|
||
| const requireNativeComponent = require('requireNativeComponent'); | ||
|
|
||
| module.exports = requireNativeComponent('RCTSlider'); |
There was a problem hiding this comment.
We want to have flow types for these components defined in these files too. Take a look at some of the other PRs as an example.
There was a problem hiding this comment.
I see. I'll modify these components.
analysis-bot
suggested changes
Jan 19, 2019
|
|
||
| type RCTSliderType = Class<NativeComponent<NativeProps>>; | ||
|
|
||
| module.exports = ((requireNativeComponent('RCTSlider'): any): RCTSliderType; |
There was a problem hiding this comment.
I think you are missing a closing paren here.
| import type {ImageSource} from 'ImageSource'; | ||
| import type {ViewStyleProp} from 'StyleSheet'; | ||
| import type {ColorValue} from 'StyleSheetTypes'; | ||
| import type {ViewProps} from 'ViewPropTypes'; | ||
| import type {SyntheticEvent} from 'CoreEventTypes'; | ||
|
|
||
| const RCTSlider = requireNativeComponent('RCTSlider'); | ||
| const RCTSliderNativeComponent = require('RCTSliderNativeComponent'); |
There was a problem hiding this comment.
Importing from an untyped module makes it any and is not safe! Did you mean to add // @flow to the top of RCTSliderNativeComponent? (untyped-import)
elicwhite
reviewed
Jan 19, 2019
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
Import Started
|
@OdaDaisuke merged commit 7e82e45 into |
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Changelog: [iOS] [Changed] - Deal with facebook#22990. Move `requireNativeComponent` to a separate file. Pull Request resolved: facebook#23048 Differential Revision: D13760373 Pulled By: cpojer fbshipit-source-id: ff8cc9d468dc3bac55fc3d4156ad695dcdd10ab8
michalchudziak
pushed a commit
to michalchudziak/react-native-slider
that referenced
this pull request
Feb 8, 2019
Summary: Changelog: [iOS] [Changed] - Deal with #22990. Move `requireNativeComponent` to a separate file. Pull Request resolved: facebook/react-native#23048 Differential Revision: D13760373 Pulled By: cpojer fbshipit-source-id: ff8cc9d468dc3bac55fc3d4156ad695dcdd10ab8
james-watkin
added a commit
to james-watkin/react-native-slider
that referenced
this pull request
Dec 28, 2021
Summary: Changelog: [iOS] [Changed] - Deal with #22990. Move `requireNativeComponent` to a separate file. Pull Request resolved: facebook/react-native#23048 Differential Revision: D13760373 Pulled By: cpojer fbshipit-source-id: ff8cc9d468dc3bac55fc3d4156ad695dcdd10ab8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
[iOS] [Changed] - Deal with #22990. Move
requireNativeComponentto a separate file.Test Plan: