Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Standalone for NativeComponents] RCTInputAccessoryView #23050

Closed
wants to merge 6 commits into from
Closed

[Standalone for NativeComponents] RCTInputAccessoryView #23050

wants to merge 6 commits into from

Conversation

doniyor2109
Copy link
Contributor

@doniyor2109 doniyor2109 commented Jan 17, 2019 •
edited
Loading

Created Standalone JS file for RCTInputAccessoryView native component #22990

Changelog:

[iOS] [Changed] - Created Standalone JS file for RCTInputAccessoryView native component

Test Plan:

  • npm run lint
  • npm run flow-check-ios
  • npm run flow
  • npm run test
  • npm run build-ios-e2e
  • npm run test-ios-e2e

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@doniyor2109
Copy link
Contributor Author

@TheSavior There was DeprecatedColorPropType. I have added it into NativeComponent. Is it ok to use it?

@elicwhite
Copy link
Member

elicwhite commented Jan 17, 2019 •
edited
Loading

Thanks for the PR!

You can use ColorValue from Stylesheet instead

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 18, 2019
facebook-github-bot
facebook-github-bot approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@doniyor2109 merged commit 3144299 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 18, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 18, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@doniyor2109 @facebook-github-bot
RCTInputAccessoryView (facebook#23050)
69757e4 
Summary:
Created Standalone JS file for RCTInputAccessoryView native component facebook#22990

Changelog:
----------

[iOS] [Changed] - Created Standalone JS file for RCTInputAccessoryView native component
Pull Request resolved: facebook#23050

Differential Revision: D13735644

Pulled By: TheSavior

fbshipit-source-id: 64b091957b38cb11d804582f185d5cb0c6754af3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: InputAccessoryView Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@doniyor2109 @facebook-github-bot @elicwhite @react-native-bot @hramos