Moved requireNativeComponent to a new file

[ajstrand]

Changelog:

[Android] [Changed] - I did some work for issue #22990. All the imports connected to requireNativeComponent in ProgressBarAndroid were moved to a separate file.

Test Plan:

• yarn test

• yarn flow

• yarn lint

Question:

@TheSavior Would the types seen here in ProgressBarAndroid.android.js need to be duplicated or moved into my new file? I wasn't sure if they are meant to be, considering they are being exported.

export type ProgressBarAndroidProps = $ReadOnly<{|
  ...ViewProps,

  /**
   * Style of the ProgressBar and whether it shows indeterminate progress (e.g. spinner).
   *
   * `indeterminate` can only be false if `styleAttr` is Horizontal, and requires a
   * `progress` value.
   */
  ...
    | {|
        styleAttr: 'Horizontal',
        indeterminate: false,
        progress: number,
      |}
    | {|
        typeAttr:
          | 'Horizontal'
          | 'Normal'
          | 'Small'
          | 'Large'
          | 'Inverse'
          | 'SmallInverse'
          | 'LargeInverse',
        indeterminate: true,
      |},
  /**
   * Whether to show the ProgressBar (true, the default) or hide it (false).
   */
  animating?: ?boolean,
  /**
   * Color of the progress bar.
   */
  color?: ?string,
  /**
   * Used to locate this view in end-to-end tests.
   */
  testID?: ?string,
|}>;

[analysis-bot]

Code analysis results:

• eslint found some issues.

[elicwhite]

Thanks for the PR!

Yeah, it would be great if you could duplicate the type and put it in the new file, typing the requireNativeComponent call.

[analysis-bot]

Code analysis results:

• eslint found some issues.

[ajstrand]

@TheSavior I've added the flow type for the native component. All of the yarn tests(flow, lint, test), still pass locally. Would there be anything else I would need to do for this PR?

I've tried testing my changes in the RNTester App, but the app crashes when I try to run it on an emulator. I don't seem to get any sort of error message either.

[elicwhite]

Thanks for updating it. You should be able to get the ci/circleci: analyze build to pass for this PR. I think the android and ios ones are broken right now on master but the analyze one looks like it has valid flow errors from your PR.

[facebook-github-bot]

@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Thank you for your PR. It turns out that this was already implemented in #23068 before you submitted a PR. I'm sorry that this caused you to do extra work :(

[ajstrand]

hey @cpojer it's ok. It wasa good exposure to react native and flow.