fix checkbox casting crash in old android versions #23281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
vonovak
changed the title
3 tasks
react-native-bot
added
Platform: Android
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 4, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: fixes casting on older android versions reported in facebook#22885 [Android] [Fixed] - fix casting crash in android checkbox Pull Request resolved: facebook#23281 Differential Revision: D13941776 Pulled By: cpojer fbshipit-source-id: ff3695f64d3399790a03b02d5b1363cacc655336
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes casting on older android versions reported in #22885
Changelog
[Android] [Fixed] - fix casting crash in android checkbox
Test Plan
run the RNTester app on android 4.4 and tick a checkbox