[GitHub] Update issue templates #23296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cpojer
reviewed
Feb 6, 2019
cpojer
reviewed
Feb 6, 2019
cpojer
reviewed
Feb 6, 2019
Contributor
Author
|
Feedback implemented! I removed the suggestion to use triple backticks around the |
hramos
commented
Feb 6, 2019
Contributor
|
Awesome! Feel free to ship it anytime. |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 6, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Go back to simpler issue template titles, with emoji. The goal is to make it easier, at a glance, to pick the right template. We also add a new "regression" template that will automatically label the issue as a regression. Other changes: - Added Christoph as a CODEOWNER for package.json and markdown file changes. Usually, any PR that touches package.json has to be imported manually by a Facebook employee. [General] [Changed] - Updated GitHub issue templates. Pull Request resolved: facebook#23296 Differential Revision: D13974378 Pulled By: hramos fbshipit-source-id: d8962a84397c16e7556ac167a3505f7c7d725915
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Go back to simpler issue template titles, with emoji. The goal is to make it easier, at a glance, to pick the right template.
We also add a new "regression" template that will automatically label the issue as a regression.
Other changes:
Changelog
[General] [Changed] - Updated GitHub issue templates.
Test Plan
Did not test.