[iOS] Fix scrollview over bounds of content size #23427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
[iOS] Fix scrollview offset out of content size Take contentInset into account
zhongwuzw
force-pushed
the
fix_scrollview_overbounds
branch
from
0a799f7
to
53a5dc7
Compare
zhongwuzw
changed the title
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhongwuzw merged commit 9c1c5a7 into |
mbardauskas
pushed a commit
to mbardauskas/react-native
that referenced
this pull request
Feb 21, 2019
Summary: Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue. Fixes like facebook#13594 facebook#22768 facebook#19970 . [iOS] [Fixed] - Fixed scrollView offset out of content size. Pull Request resolved: facebook#23427 Differential Revision: D14162663 Pulled By: cpojer fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
hramos
removed
Import Started
grabbou
pushed a commit
that referenced
this pull request
Mar 22, 2019
Summary: Fix scrollview `offset` out of content size in iOS, Android uses `scrollTo` and `smoothScrollTo` which not have this issue. Fixes like #13594 #22768 #19970 . [iOS] [Fixed] - Fixed scrollView offset out of content size. Pull Request resolved: #23427 Differential Revision: D14162663 Pulled By: cpojer fbshipit-source-id: a95371c8d703b6d5f604af0072f86c01c2018f4a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix scrollview
offsetout of content size in iOS, Android usesscrollToandsmoothScrollTowhich not have this issue.Fixes like #13594 #22768 #19970 .
Changelog
[iOS] [Fixed] - Fixed scrollView offset out of content size.
Test Plan
Assign scrollView a big offset which greater than content size plus content inset, we should keep offset in the area of content size plus content inset.
We can use reproduce example in #13594 or #22768 .