bump targetSdkVersion to 28 #23431
Closed
bump targetSdkVersion to 28 #23431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cpojer
approved these changes
Feb 13, 2019
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@cpojer maybe we can cherry pick it to 0.59, because Android Studio is highlighting targetSdkVersion and suggesting to use the latest one. But I don't have opinion about it. |
|
@dulmandakh merged commit 57f444b into |
grabbou
pushed a commit
that referenced
this pull request
Feb 13, 2019
Summary: Bump targetSdkVersion to 28 [Android] [Changed] - Bump targetSdkVersion to 28 Pull Request resolved: #23431 Differential Revision: D14065177 Pulled By: cpojer fbshipit-source-id: a161d1d385b7b40ec93d70851e5a41baeb58f830
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Bump targetSdkVersion to 28 [Android] [Changed] - Bump targetSdkVersion to 28 Pull Request resolved: facebook/react-native#23431 Differential Revision: D14065177 Pulled By: cpojer fbshipit-source-id: a161d1d385b7b40ec93d70851e5a41baeb58f830
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bump targetSdkVersion to 28
Changelog
[Android] [Changed] - Bump targetSdkVersion to 28
Test Plan
CI is green, and apps will work as usual.