Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow to 0.97.0 #24437

Closed
wants to merge 1 commit into from

Conversation

friederbluemle
Copy link
Contributor

Summary

This updates the flow-bin dependency from 0.96.0 to 0.97.0, fixing the following error:

Wrong version of Flow. The config specifies version ^0.96.0 but this is version 0.97.0
Flow check failed.

0.97.0 was released yesterday, and is now causing CI build failures in different PRs, for example: #24425 #24435 #24436

It may be beneficial to specify the flow-bin dependency in package.json as 0.97.0 instead of ^0.97.0. Thoughts?

Changelog

[General] [Changed] - Update flow to 0.97.0

Test Plan

Successfully ran:

yarn flow
yarn flow-check-android
yarn flow-check-ios

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 13, 2019
@pull-bot
Copy link

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 320d562

@cpojer
Copy link
Contributor

cpojer commented Apr 14, 2019

Thank you for your pull request. Unfortunately flow can only be upgraded by Facebook employees. You should see a flow upgrade land on master in the next few days.

@cpojer cpojer closed this Apr 14, 2019
@friederbluemle
Copy link
Contributor Author

Thanks @cpojer - Looking forward to it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants