onKeyPress is not fired on Android when entering an Emoji #24717
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| dispatchKeyEventOrEnqueue(key); | ||
| } | ||
|
|
||
| // Detect, if text is unicode | ||
| if (key.length() == 2) { |
There was a problem hiding this comment.
WDYT about changing condition from line 112 to if (key.length() <= 2) instead?
There was a problem hiding this comment.
Yes, great idea. I separated it, because I wanted to make it cleaner, but it is better to remove unnecessary ifology.
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by Piotr Trocki in a5c57b4. When will my fix make it into a release? | Upcoming Releases |
Summary
Resolve #24690
Question
This is very simple unicode detecting. Should I improve this solution creating StringsUtils for detecting unicodes in whole react-native project ?
Changelog
[Android][Fixed] onKeyPress method is calling, when user type emoji
Test Plan