-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TM] Add specs for AccessibilityInfo #24891
[TM] Add specs for AccessibilityInfo #24891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 😁
However, before we land this PR, I have a few question/concerns that I'd like you to address.
Libraries/Components/AccessibilityInfo/NativeAccessibilityInfo.js
Outdated
Show resolved
Hide resolved
Libraries/Components/AccessibilityInfo/NativeAccessibilityInfo.js
Outdated
Show resolved
Hide resolved
Libraries/Components/AccessibilityInfo/NativeAccessibilityInfo.js
Outdated
Show resolved
Hide resolved
Libraries/Components/AccessibilityInfo/NativeAccessibilityInfo.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @michalchudziak in 67c3ed3. When will my fix make it into a release? | Upcoming Releases |
Summary: Part of facebook#24875 ## Changelog [General] [Added] - Add TurboModule spec for AccessibilityInfo Pull Request resolved: facebook#24891 Reviewed By: fkgozali Differential Revision: D15394913 Pulled By: RSNara fbshipit-source-id: e66e7b7fc4451575b5022695f125c15f9f4b707e
Summary
Part of #24875
Changelog
[General] [Added] - Add TurboModule spec for AccessibilityInfo
Test Plan
Run
yarn flow
on the root level