Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TM] add spec for JSDevSupport #24905

Closed
wants to merge 3 commits into from

Conversation

ericlewis
Copy link
Contributor

Summary

Part of #24875.

Changelog

[General] [Added] - add TM spec for JSDevSupport

Test Plan

Flow passes

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels May 16, 2019
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label May 16, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

Libraries/Utilities/JSDevSupportModule.js Outdated Show resolved Hide resolved
Libraries/Utilities/JSDevSupportModule.js Outdated Show resolved Hide resolved
Libraries/Utilities/JSDevSupportModule.js Outdated Show resolved Hide resolved
Libraries/Utilities/JSDevSupportModule.js Outdated Show resolved Hide resolved
@ericlewis ericlewis added the Flow label May 16, 2019
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @ericlewis in d7a5e3e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 22, 2019
M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this pull request Mar 10, 2020
Summary:
Part of facebook#24875.

## Changelog

[General] [Added] - add TM spec for JSDevSupport
Pull Request resolved: facebook#24905

Reviewed By: fkgozali

Differential Revision: D15391754

Pulled By: rickhanlonii

fbshipit-source-id: afca6ce3d6bcfaaf097e13c148496cdd1f062465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Flow Merged This PR has been merged. Native Module Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants