[TM] Add Spec for ImageEditor #24921
Conversation
react-native-bot
added
API: ImageEditor
Component: Image
Type: Enhancement
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Libraries/Image/NativeImageEditor.js
Outdated
| ) => void; | ||
| } | ||
|
|
||
| export default TurboModuleRegistry.getEnforcing<Spec>('NativeImageEditor'); |
There was a problem hiding this comment.
this should be ImageEditingManager instead
There was a problem hiding this comment.
Got it ! do I need to update call-sites too?
| height: number, | ||
| |}, | ||
|
|
||
| resizeMode?: ?$Enum<{ |
There was a problem hiding this comment.
are these optional because android doesn't have them? if so, group and mark: // iOS only
There was a problem hiding this comment.
@fkgozali has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @yjose in d2ef114. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR solves part of this issue: facebook#24875 ## Changelog [General] [Added] - TM Spec for ImageEditor Pull Request resolved: facebook#24921 Reviewed By: rickhanlonii Differential Revision: D15471058 Pulled By: fkgozali fbshipit-source-id: f01539fc8acea95fca27ce7bb4b4169ffe138d93
Summary
This PR solves part of this issue: #24875
Changelog
[General] [Added] - TM Spec for ImageEditor
Test Plan
Flow passes.