Do not run packager in Release mode #24929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@cpojer, @grabbou & @deepsweet: please review. |
react-native-bot
added
the
Tech: Bundler 📦
facebook-github-bot
approved these changes
May 17, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
deepsweet
approved these changes
May 17, 2019
|
Diff got stuck, let me try again. |
|
This pull request was successfully merged by @lucasbento in 4ea6204. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: This PR fixes a regression introduced on [3273d23](facebook@3273d23#diff-883359f85083d00b7266ec2acebcca9f) that removed facebook#23938. It also adds the check for `React` and `React-tvOS` targets. ## Changelog [IOS] [FIXED] - Do not run packager in Release mode Pull Request resolved: facebook#24929 Differential Revision: D15391692 Pulled By: cpojer fbshipit-source-id: c2e524108be3bf1e45b0d0ff7cddd9785b51a60f
|
How can I check the fix version. Is this issue on 0.59 and fix in 0.60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression introduced on 3273d23 that removed #23938.
It also adds the check for
ReactandReact-tvOStargets.Changelog
[IOS] [FIXED] - Do not run packager in Release mode
Test Plan
Run RNTester in Release mode - packager shouldn't start anymore