Add default scrollEventThrottle to Animated{FlatList, SectionList} #24954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
react-native-bot
added
API: Animated
Component: FlatList
Component: SectionList
Type: Enhancement
facebook-github-bot
approved these changes
May 20, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @janicduplessis in 933e65e. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
…acebook#24954) Summary: `scrollEventThrottle` is often a source of confusion, especially when using native animated since users expect that it doesn't affect `Animated.event` but it does. We added a default prop to Animated.ScrollView but not to `Animated.FlatList` and `Animated.SectionList` so this adds it for those. ## Changelog [JavaScript] [Added] - Add default scrollEventThrottle to Animated{FlatList, SectionList} Pull Request resolved: facebook#24954 Differential Revision: D15411998 Pulled By: cpojer fbshipit-source-id: 41589a96c0a8b75ae7cf3169ccef363ac5140ad3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scrollEventThrottleis often a source of confusion, especially when using native animated since users expect that it doesn't affectAnimated.eventbut it does. We added a default prop to Animated.ScrollView but not toAnimated.FlatListandAnimated.SectionListso this adds it for those.Changelog
[JavaScript] [Added] - Add default scrollEventThrottle to Animated{FlatList, SectionList}
Test Plan
Tested that it is no longer needed to pass
scrollEventThrottleto have smoothonScrollanimations on iOS