[Internal] [Fix] - Install watchman in e2e tests to fix CI #25257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
|
E2E tests are fixed, yay! Now coveralls, looks like we hit this: lemurheavy/coveralls-public#632 |
cpojer
approved these changes
Jun 13, 2019
thymikee
force-pushed
the
chore/brew-watchman
branch
from
4a8280b to
1ebc879
Compare
|
@cpojer yap! Just force-pushed that |
facebook-github-bot
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
thymikee
changed the title
thymikee
changed the title
|
This pull request was successfully merged by @thymikee in 488a91b. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: An attempt to fix CI. This PR includes changes from facebook#25241, to be removed once synced to master ## Changelog [General] [Fix] - install watchman in e2e tests to fix CI Pull Request resolved: facebook#25257 Differential Revision: D15804513 Pulled By: cpojer fbshipit-source-id: 33d4494ffaa340f99f1dae8764449e81e552c943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An attempt to fix CI.
This PR includes changes from #25241, to be removed once synced to master
Changelog
[Internal] [Fix] - Install watchman in e2e tests to fix CI
Test Plan
Happy CI