-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Remove asl_log (Fixes #25380) #25382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's kill it.
@JonnyBurger it seems we have tests for this. Can you check out |
I don't see immediately which tests have to be changed D: Running out of time this week, I asked @Kida007 if he can take a look tomorrow otherwise will try to get it merge ready next week! |
I think this is actually a CI issue and not an issue with your change. Let me try to land it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @JonnyBurger in 3b88f07. When will my fix make it into a release? | Upcoming Releases |
Summary: By default absolutely everything gets logged twice (facebook/react-native#25380). This was introduced over 4 years ago here: [React Native Log to ASL · facebook/react-native@d1b14ef · GitHub](facebook/react-native@d1b14ef) with the reason to support ASL. With this PR the support for that will be removed but I believe this is justified because: - the benefit of not having every log message twice far outweighs the benefit of having Apple System Log. - ASL was superseded by "unified logging" (yellow box on https://developer.apple.com/documentation/os/logging). - I assume that people who use asl_log is very small. There is also very little information about it on the internet ## Changelog [iOS] [Fixed] - Logs would get printed twice Pull Request resolved: facebook/react-native#25382 Differential Revision: D16048052 Pulled By: cpojer fbshipit-source-id: 51519570bbee79571e4ff63f433b9b70bcd55671
Summary: By default absolutely everything gets logged twice (facebook/react-native#25380). This was introduced over 4 years ago here: [React Native Log to ASL · facebook/react-native@d1b14ef · GitHub](facebook/react-native@d1b14ef) with the reason to support ASL. With this PR the support for that will be removed but I believe this is justified because: - the benefit of not having every log message twice far outweighs the benefit of having Apple System Log. - ASL was superseded by "unified logging" (yellow box on https://developer.apple.com/documentation/os/logging). - I assume that people who use asl_log is very small. There is also very little information about it on the internet ## Changelog [iOS] [Fixed] - Logs would get printed twice Pull Request resolved: facebook/react-native#25382 Differential Revision: D16048052 Pulled By: cpojer fbshipit-source-id: 51519570bbee79571e4ff63f433b9b70bcd55671
Hmmm, are we sure that I don't see any mention of |
Sorry for causing trouble. So that it writes out and also prints to Console.app. Maybe we can use 'unified logging' (see above) instead? |
IMO, we should ditch Here's an implementation of |
The only issue is that it replicates the timestamp, so we should remove the Example:
edit: To be less of a breaking change, maybe just pass |
@cpojer Want me to send a PR for the two comments above? |
Now it doesnt Log in Console App. How to view logs in Release build now ? |
Sorry @damandeepsingh93 for breaking this. I think the correct behavior would then be to do asl_log in production and normal log in development? |
Summary: By default absolutely everything gets logged twice (facebook#25380). This was introduced over 4 years ago here: [React Native Log to ASL · facebook/react-native@d1b14ef · GitHub](facebook@d1b14ef) with the reason to support ASL. With this PR the support for that will be removed but I believe this is justified because: - the benefit of not having every log message twice far outweighs the benefit of having Apple System Log. - ASL was superseded by "unified logging" (yellow box on https://developer.apple.com/documentation/os/logging). - I assume that people who use asl_log is very small. There is also very little information about it on the internet ## Changelog [iOS] [Fixed] - Logs would get printed twice Pull Request resolved: facebook#25382 Differential Revision: D16048052 Pulled By: cpojer fbshipit-source-id: 51519570bbee79571e4ff63f433b9b70bcd55671
Summary
By default absolutely everything gets logged twice (#25380).
This was introduced over 4 years ago here:
React Native Log to ASL · facebook/react-native@d1b14ef · GitHub
with the reason to support ASL.
With this PR the support for that will be removed but I believe this is justified because:
Changelog
[iOS] [Fixed] - Logs would get printed twice