Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade bundled JSC to jsc-android@245459.0.0.
This PR is to address #24261 and specific for RN 0.59.
More details please refer to #25426
NOTE that this PR is branched from 0.59-stable and should be merged or cherry-picked into 0.59-stable branch only.
Changelog
[Android] [Fixed] - Upgrade jsc-android to r245459 and fix crash on Samsung S7 Edge
Test Plan
./gradlew clean :ReactAndroid:installArchives
and unzip generatedandroid/com/facebook/react/react-native/0.59.9/react-native-0.59.9.aar
.Use
strings jni/arm64-v8a/libjsc.so | grep -C 1 JavaScriptCore.Version
to verify the output should be something like245459.0.0
in adb logcat output.