Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Remove max depth parameter while measuring layout of shadow view #26986

Closed

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Oct 24, 2019

Summary

Searching for the ancestor view while measuring a shadow view layout relative to the ancestor is limited to 30. I couldn't find the reason nor commit where it was introduced (because I have no access to internal facebook commits).
I think we should keep looking for an ancestor view until the shadow view has the superview property.

Changelog

[iOS] [Fixed] - Remove maximum searching depth while measuring layout.

Test Plan

  • Tested if RNTester works as expected.
  • Tested in app with a lot of nested flatlists where sometimes I was facing this redbox because of the max depth limit.

Screenshot 2019-10-24 at 14 40 11

@dratwas dratwas requested a review from shergin as a code owner October 24, 2019 12:43
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Oct 24, 2019
@react-native-bot react-native-bot added Platform: iOS iOS applications. Bug labels Oct 24, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @dratwas in 2f8328d.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants