ReactEditText extends AppCompatEditText #27039
Conversation
facebook-github-bot
added
CLA Signed
dulmandakh
force-pushed
the
appcompat-edittext
branch
from
b8cbbde
to
f7c5272
Compare
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulmandakh This PR failed to land because there are internal components that inherit from ReactTextInputManager that now require to import the androidx.appcompat.widget.AppCompatEditText dependency. |
|
@mdvacca you can use provided_deps to exported_deps, and it'll work |
| import androidx.annotation.Nullable; | ||
| import androidx.core.view.AccessibilityDelegateCompat; | ||
| import androidx.core.view.ViewCompat; | ||
| import androidx.appcompat.widget.AppCompatEditText; |
There was a problem hiding this comment.
Minor: Keep in alphabetical order please (should be inserted above androidx.core)
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @dulmandakh in aaa2765. When will my fix make it into a release? | Upcoming Releases |
Summary
Google recommends to extend AppCompat widgets, and Android Studio suggests the change. This PR changes ReactEditText to extend AppCompatEditText.
Changelog
[Android] [Changed] - ReactEditText extends AppCompatEditText
Test Plan
CI is green