-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flipper to default template on Android and iOS #27569
Conversation
Wow this is great! What's the CI failure? |
|
@rickhanlonii the failed CI has been a known issue. The master build for that is failing as well. You can cherry pick: RNTester implementation is not consistent with 0.62 implementation. I can update that to match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit
I think after #27837, this should be good to go. |
Is this good to go now? |
I think so! |
This pull request was successfully merged by @safaiyeh in 52cd9cd. When will my fix make it into a release? | Upcoming Releases |
Summary: Issue: #27565 initalizeFlipper should be set in template app by default. ## Changelog [iOS] [Changed] - Added Flipper to template app [Android] [Changed] - Added Flipper to template app Pull Request resolved: #27569 Test Plan: Connect Flipper to the iOS application Connect Flipper to the Android application Reviewed By: passy Differential Revision: D19344704 Pulled By: rickhanlonii fbshipit-source-id: ca126fd2caab13751ddc2ce6d195bd0c644c704e
…7569) Summary: Issue: facebook#27565 initalizeFlipper should be set in template app by default. ## Changelog [iOS] [Changed] - Added Flipper to template app [Android] [Changed] - Added Flipper to template app Pull Request resolved: facebook#27569 Test Plan: Connect Flipper to the iOS application Connect Flipper to the Android application Reviewed By: passy Differential Revision: D19344704 Pulled By: rickhanlonii fbshipit-source-id: ca126fd2caab13751ddc2ce6d195bd0c644c704e
Summary
Issue: #27565
initalizeFlipper should be set in template app by default.
Changelog
[iOS] [Changed] - Added Flipper to template app
[Android] [Changed] - Added Flipper to template app
Test Plan
Connect Flipper to the iOS application
Connect Flipper to the Android application